Incidental patch cleaning?

[Andrew Talbot]

Hi,

Is it possible to sneak in a bit of patch cleaning within the new software? It would be useful to incidentally remove any trailing white space that happens to exist within the scope of a patch.

[Rob Shearman]

Hi Andrew,

2008/8/19 Andrew Talbot :
> Hi,
>
> Is it possible to sneak in a bit of patch cleaning within the new software? It would be useful to incidentally remove any trailing white space that happens to exist within the scope of a patch.

Patchwatcher currently only looks at patches going to the mailing list
and Alexandre still gets the patches from the mailing list. To do as
you suggest would mean making Patchwatcher a filter before the mailing
list and make it change the patches. I don't think this is a good idea
because then what a developer sends isn't necessarily exactly the same
as what everyone else receives.

Besides, I think the git tools allow filtering of trailing whitespace
for patches being applied and I think Alexandre does this.

[Kai Blin]

On Tuesday 19 August 2008 18:38:18 Andrew Talbot wrote:
> Hi,
>
> Is it possible to sneak in a bit of patch cleaning within the new software?
> It would be useful to incidentally remove any trailing white space that
> happens to exist within the scope of a patch.

While I wouldn't mind issuing a warning for patches that add whitespace 
errors, I'm against any "automagical" fix-ups for patches. I don't mind 
Alexandre changing little issues, even though that'll break git-rebase, but I 
wouldn't trust a program to do the same.

Cheers,
Kai