On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon bsjeon@hanmail.net wrote:
By an analysis of the ImmIsUIMessageA/W disassemble code,
- checked msg :
WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, WM_IME_SETCONTEXT, WM_IME_NOTIFY, WM_IME_COMPOSITIONFULL, WM_IME_SELECT. 2. SendMessageA/W is used.
Writing code for Wine based directly off of disassembled code is not allowed. The only way disassembly can be used is clean-room reverse engineering where person A disassembles the code and writes up a very high-level spec file for person B to implement. Unfortunately, this patch cannot be committed and you won't be able to submit patches for the imm32 module anymore.
Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue to contribute and we do not compromise the source code.
I have not looked at these patches yet so just send me an e-mail describing what they do.
-aric
James Hawkins wrote:
On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon bsjeon@hanmail.net wrote:
By an analysis of the ImmIsUIMessageA/W disassemble code,
- checked msg :
WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, WM_IME_SETCONTEXT, WM_IME_NOTIFY, WM_IME_COMPOSITIONFULL, WM_IME_SELECT. 2. SendMessageA/W is used.
Writing code for Wine based directly off of disassembled code is not allowed. The only way disassembly can be used is clean-room reverse engineering where person A disassembles the code and writes up a very high-level spec file for person B to implement. Unfortunately, this patch cannot be committed and you won't be able to submit patches for the imm32 module anymore.
Aric Stewart aric@codeweavers.com writes:
Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue to contribute and we do not compromise the source code.
No, please don't do that. We don't want to have people disassemble Windows code at all, even to write high level descriptions. There's simply no need for it, just write test cases.
Ahh ok, thanks. Will do.
-aric
Alexandre Julliard wrote:
Aric Stewart aric@codeweavers.com writes:
Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue to contribute and we do not compromise the source code.
No, please don't do that. We don't want to have people disassemble Windows code at all, even to write high level descriptions. There's simply no need for it, just write test cases.
-
Alexandre Julliard -
Aric Stewart -
James Hawkins