Wine and Smatch

[Michael Stefaniuc]

Hello,

I've written a web page about Wine and Smatch:
http://people.redhat.com/mstefani/wine/smatch/

It includes also a table with the bugs found by the smatch scripts. I
could need a hand with the bugs (status BUG, UKNOWN) cause I don't know
how to fix them correctly (and for some locking BUG's i am not sure that
they are real bugs).

Now that the fight with the web page is over I can go to write more
smatch scripts ;).

bye
    michael

[Alexandre Julliard]

Michael Stefaniuc  writes:
> It includes also a table with the bugs found by the smatch scripts. I
> could need a hand with the bugs (status BUG, UKNOWN) cause I don't know
> how to fix them correctly (and for some locking BUG's i am not sure that
> they are real bugs).

The ones in gdiobj.c and win.c are not bugs, the functions are
supposed to return with the lock held. There should be a matching
GDI_ReleaseObj/WIN_ReleasePtr after each call though.

[Michael Stefaniuc]

On Mon, Mar 03, 2003 at 11:03:07AM -0800, Alexandre Julliard wrote:
> Michael Stefaniuc  writes:
> > It includes also a table with the bugs found by the smatch scripts. I
> > could need a hand with the bugs (status BUG, UKNOWN) cause I don't know
> > how to fix them correctly (and for some locking BUG's i am not sure that
> > they are real bugs).
>
> The ones in gdiobj.c and win.c are not bugs, the functions are
> supposed to return with the lock held. There should be a matching
> GDI_ReleaseObj/WIN_ReleasePtr after each call though.

Thanks. So they are basicaly only "wrappers" around the locking function
and can be treated as locking functions themself. Updated wine_locks.pl
and the website acordingly.

bye
    michael

[Eric Pouech]

Michael Stefaniuc wrote:
> Hello,
>
> I've written a web page about Wine and Smatch:
> http://people.redhat.com/mstefani/wine/smatch/

- there's a return in excess in programs/wcmd/builtins.c
- we shouldn't return 0 in dlls/winmm/wineoss/audio.c (as the comment 
says ;-)
- the code in programs/winhelp/hlpfile.c is correct

A+

[Michael Stefaniuc]

On Mon, Mar 03, 2003 at 08:28:33PM +0100, Eric Pouech wrote:
> Michael Stefaniuc wrote:
> > I've written a web page about Wine and Smatch:
> > http://people.redhat.com/mstefani/wine/smatch/
> - there's a return in excess in programs/wcmd/builtins.c

That return needs to be deleted only?
> - we shouldn't return 0 in dlls/winmm/wineoss/audio.c (as the comment
>
> says ;-)

I've read the comment but the script dosn't complain about the return,
it complains about the ExitThread(0) before it. This is after a switch
embeded into a while loop and smatch seems to not handle this quite
correctly. I've change the status to NOTABUG.
> - the code in programs/winhelp/hlpfile.c is correct

Same like before, but this already had the NOTABUG status.

bye
    michael