On Thu, Dec 30, 2004 at 07:57:31AM -0800, Jon Griffiths wrote:
Hi,
After applying, include/heap.h can be removed from cvs.
To be honest, I'm not too happy with this patch, HEAP_strdupWtoA was a good marker for code that needed fixing, this patch just makes those places harder to find.
On Thu, 30 Dec 2004 15:41:06 -0500, Dimitrie O. Paun wrote:
To be honest, I'm not too happy with this patch, HEAP_strdupWtoA was a good marker for code that needed fixing, this patch just makes those places harder to find.
I don't really understand why we can't make this an inline or something, it seems that it's a lot more convenient than the direct win32 equivalents. Making it an inline would achieve the same effect as simply replacing each usage manually, and allow us to improve DLL separation as well.
On Thu, Dec 30, 2004 at 09:08:58PM +0000, Mike Hearn wrote:
I don't really understand why we can't make this an inline or something, it seems that it's a lot more convenient than the direct win32 equivalents. Making it an inline would achieve the same effect as simply replacing each usage manually, and allow us to improve DLL separation as well.
Because in 99.99% of cases you don't want to convert from W->A. If all our functions are Unicode, a W->A conversion is a warning sign, and for sure you wouldn't want to encourage people to do so by making it any easier.