Re: winsock: use iphlpapi

[Dimitrie O. Paun]

On Thu, 8 May 2003, Juan Lang wrote:
> Sylvain was right, I screwed up the last patch.  Here
> 'tis again.

Juan,

Your patches are hard to review, as you compress them.
Please include them in your message as plain text
if you can do it without line wraps, if not attach
them as plain text files. Here are some tips on
sending patches:
    http://www.winehq.org/?page=sending_patches

Thanks!

winsock: use iphlpapi

[Sylvain Petreolle]

Dimitrie,
his last patch is working like a dream...
I think he sent it as gz because of wrapping problems.
is it too difficult to use gunzip ? :)
> Juan,
>
> Your patches are hard to review, as you compress them.
> Please include them in your message as plain text
> if you can do it without line wraps, if not attach
> them as plain text files. Here are some tips on
> sending patches:
>     http://www.winehq.org/?page=sending_patches

=====
Sylvain Petreolle (spetreolle at users dot sourceforge dot net) ICQ #170597259
No more War !

"What if tomorrow the War could be over ?" Morpheus, in "Reloaded".

For the Law of Oil and Fire, Im an European that lives in France.
For all my Brothers and friends, Im a human living on Earth.

___________________________________________________________
Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français !
Yahoo! Mail : http://fr.mail.yahoo.com

winsock: use iphlpapi

[Dimitrie O. Paun]

On Thu, 8 May 2003, Sylvain Petreolle wrote:
> Dimitrie,
> his last patch is working like a dream...

Cool -- glad to hear that!
> I think he sent it as gz because of wrapping problems.
> is it too difficult to use gunzip ? :)

It is inconvenient, yes. We went over this a million times,
there is a reason why we recommend that patches are either
inlined or attached as plain text. I am not trying to put
Juan down, I'm just pointing out the prefered way of 
submitting patches for Wine. Am I a bad person? :)

winsock: use iphlpapi

[Juan Lang]

--- "Dimitrie O. Paun"  wrote:
> > is it too difficult to use gunzip ? :)
>
> It is inconvenient, yes. We went over this a million
> times,
> there is a reason why we recommend that patches are
> either
> inlined or attached as plain text.

Just curious, is this what prevented the (winsock,
wsock32, netapi32) patches from getting committed? 
I'll gladly resubmit was uncompressed if so.  I didn't
get any other feedback on these.

--Juan

__________________________________
Do you Yahoo!?
Yahoo! Calendar - Free online calendar with sync to Outlook(TM).
http://calendar.yahoo.com