Re: msi patch submission - cond.y

[Mike McCormack]

EA Durbin wrote:
> fixed various SQL errors in COND_GetOperator() and compare_int()

IMO, both of your patches are incorrect.  I'm waiting for your test case.

Mike

msi patch submission - cond.y

[EA Durbin]

Is IGE not is greater than or equal to, and shouldn't the sign for that be
> = rather than <=, or does IGE mean something else, perfect example of were

comments should be, after all the function should be written perfectly so it 
can be interpreted without any comments in the code.

After all Hans fixed the ILE in compare-int() so he must have assumed the 
same thing I did from that block of code. Or does ILE and IGE mean something 
totally different than is Greater than or equal to, or is less than or equal 
to? We don't know we didn't write the code and we're trying to view it from 
an outside perspective to determine how it works.
> From: Mike McCormack 
> To: EA Durbin 
> CC: [e-mail]
> Subject: Re: msi patch submission - cond.y
> Date: Mon, 05 Jun 2006 19:37:43 +0900
>
> EA Durbin wrote:
> > fixed various SQL errors in COND_GetOperator() and compare_int()
>
> IMO, both of your patches are incorrect.  I'm waiting for your test case.
>
> Mike

msi patch submission - cond.y

[Hans Leidekker]

On Monday 05 June 2006 15:33, EA Durbin wrote:
> Is IGE not is greater than or equal to, and shouldn't the sign for that be
> > = rather than <=, or does IGE mean something else, perfect example of
>
> were comments should be, after all the function should be written perfectly

I don't think that's entirely fair to Mike, IMO his code is about the
most readable I have encountered in Wine. The meaning of the constant
IGE can be easily deduced from reading the code. Furthermore, a little
searching turned up this:

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/msi/setup/c...

i.e. an overview of msi condition operators.

-Hans