Re: ddraw.h: disable DDEVICEIDENTIFIER size alignment

[Stefan Dösinger]

Am 11.10.2009 um 17:44 schrieb Markus Stockhausen:
> <diff.patch>

Did you compile this test with MSVC and the Microsoft headers on  
Windows?

ddraw.h: disable DDEVICEIDENTIFIER size alignment

[Markus Stockhausen]

Am Sonntag, den 11.10.2009, 18:04 +0200 schrieb Stefan Dösinger:
> Am 11.10.2009 um 17:44 schrieb Markus Stockhausen:
> > <diff.patch>
>
> Did you compile this test with MSVC and the Microsoft headers on  
> Windows?

I'm sorry but I have no Windows environment. Only Linux/GCC.

ddraw.h: disable DDEVICEIDENTIFIER size alignment

[Dmitry Timoshkov]

"Markus Stockhausen"  wrote:
> > Did you compile this test with MSVC and the Microsoft headers on  
> > Windows?
>
> I'm sorry but I have no Windows environment. Only Linux/GCC.

I have compiled the test alone and it fails here:

ddrawmodes.c:37: Test failed: DDDEVICEIDENTIFIER2 too large (misaligned)

It's natural that the structure is 8-byte aligned since it has a
64-bit member (LARGE_INTEGER). ddraw.h in PSDK doesn't have any
forced packing either.

ddraw.h: disable DDEVICEIDENTIFIER size alignment

[Markus Stockhausen]

Am Montag, den 12.10.2009, 02:01 +0900 schrieb Dmitry Timoshkov:
> I have compiled the test alone and it fails here:
>
> ddrawmodes.c:37: Test failed: DDDEVICEIDENTIFIER2 too large (misaligned)
>
> It's natural that the structure is 8-byte aligned since it has a
> 64-bit member (LARGE_INTEGER). ddraw.h in PSDK doesn't have any
> forced packing either.

Thanks for the help. But what about older applications/compilers that
determined the size to be 4 bytes less and therefore reserved not enough
stack space for the result structure. At least
http://bugs.winehq.org/show_bug.cgi?id=12869 fails because of this.

Should a patch better fix the copy behaviour of GetDeviceIdentifier()?

help with native test: GetDeviceIdentifier() memory overwrite

[Markus Stockhausen]

Thanks to Dimitry I have changed the test. Maybe someone could check if
the attached one works in native while it fails in my Wine environment.

Thanks a lot in advance.

Markus

help with native test: GetDeviceIdentifier() memory overwrite

[Dmitry Timoshkov]

"Markus Stockhausen"  wrote:
> Thanks to Dimitry I have changed the test. Maybe someone could check if
> the attached one works in native while it fails in my Wine environment.

New test passes under XP.