Re: advapi32: add LookupSecurityDescriptorPartsA/W stubs (resend)

[Sebastian Lackner]

On 13.02.2017 09:23, Austin English wrote:
> Originally sent in November, with no comments:
> https://source.winehq.org/patches/data/127657
>
> Fixes https://bugs.winehq.org/show_bug.cgi?id=41682
>
> -- -Austin GPG: 14FB D7EA A041 937B
>
> 0001-advapi32-add-LookupSecurityDescriptorPartsA-W-stubs.patch
>
> From eebe82acd3fd4828a74b38c97f260ddfd2143b83 Mon Sep 17 00:00:00 2001
> From: Austin English 
> Date: Wed, 9 Nov 2016 21:43:18 -0600
> Subject: [PATCH] advapi32: add LookupSecurityDescriptorPartsA/W stubs
> Signed-off-by: Austin English
>
> dlls/advapi32/advapi32.spec |  4 ++--
>  dlls/advapi32/security.c    | 24 ++++++++++++++++++++++++
>  2 files changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec
> index 6c57c88..88d8634 100644
> --- a/dlls/advapi32/advapi32.spec
> +++ b/dlls/advapi32/advapi32.spec
> @@ -415,8 +415,8 @@
>  @ stdcall LookupPrivilegeNameW(wstr ptr ptr ptr)
>  @ stdcall LookupPrivilegeValueA(ptr ptr ptr)
>  @ stdcall LookupPrivilegeValueW(ptr ptr ptr)
> -# @ stub LookupSecurityDescriptorPartsA
> -# @ stub LookupSecurityDescriptorPartsW
> +@ stdcall LookupSecurityDescriptorPartsA(ptr ptr ptr ptr ptr ptr ptr)
> +@ stdcall LookupSecurityDescriptorPartsW(ptr ptr ptr ptr ptr ptr ptr)
>  @ stdcall LsaAddAccountRights(ptr ptr ptr long)
>  @ stub LsaAddPrivilegesToAccount
>  # @ stub LsaClearAuditLog
> diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
> index 7e41c0a..b094015 100644
> --- a/dlls/advapi32/security.c
> +++ b/dlls/advapi32/security.c
> @@ -6087,3 +6087,27 @@ BOOL WINAPI SaferSetLevelInformation(SAFER_LEVEL_HANDLE handle, SAFER_OBJECT_INF
>      FIXME("(%p %u %p %u) stub\n", handle, infotype, buffer, size);
>      return FALSE;
>  }
> -
>
> +/******************************************************************************
> -
> - LookupSecurityDescriptorPartsA   [ADVAPI32.@]
> - */
>
> +DWORD WINAPI LookupSecurityDescriptorPartsA(TRUSTEEA *owner, TRUSTEEA *group, ULONG *access_count,
> -
>                                        EXPLICIT_ACCESSA *access_list, ULONG *audit_count,
> -
>                                        EXPLICIT_ACCESSA *audit_list, SECURITY_DESCRIPTOR *descriptor)
>
> +{
> - FIXME("stub:%p %p %p %p %p %p %p\n", owner, group, access_count,
> -
>      access_list, audit_count, audit_list, descriptor);
> - return ERROR_SUCCESS;

It would be better to return failure when the stub doesn't do anything useful.
> +}
> -
>
> +/******************************************************************************
> -
> - LookupSecurityDescriptorPartsW   [ADVAPI32.@]
> - */
>
> +DWORD WINAPI LookupSecurityDescriptorPartsW(TRUSTEEW *owner, TRUSTEEW *group, ULONG *access_count,
> -
>                                        EXPLICIT_ACCESSW *access_list, ULONG *audit_count,
> -
>                                        EXPLICIT_ACCESSW *audit_list, SECURITY_DESCRIPTOR *descriptor)
>
> +{
> - FIXME("stub:%p %p %p %p %p %p %p\n", owner, group, access_count,
> -
>      access_list, audit_count, audit_list, descriptor);
> - return ERROR_SUCCESS;
>
> +}
> -- 2.10.2