Re: PATCH: controls/menu.c case ranges

[Alexandre Julliard]

Marcus Meissner  writes:
> Another try on fixing the case range problems (WORD is unsigned, 
> HBMMENU_CALLBACK is -1, so out of range of the switch).

I think this is revealing a deeper problem with that code, the magic
value check should be done against the whole handle, not just the low
word.

PATCH: controls/menu.c case ranges

[Marcus Meissner]

On Thu, Jul 22, 2004 at 02:34:20PM -0700, Alexandre Julliard wrote:
> Marcus Meissner  writes:
> > Another try on fixing the case range problems (WORD is unsigned, 
> > HBMMENU_CALLBACK is -1, so out of range of the switch).
>
> I think this is revealing a deeper problem with that code, the magic
> value check should be done against the whole handle, not just the low
> word.

Hmm.

It just special cases those specific handle values.

But yes, casting to (WORD) is wrong here if normal handles can appear too.

Ciao, marcus