Hi,
Was there something wrong with the following patches? I received no warnings or errors when patching and compiling one-by-one. Also, Akihiro Sagawa reviewed and passed them.
103117 [1/4] regsvr32: Insert unicode print function (http://source.winehq.org/patches/data/103117) 103118 [2/4] regsvr32: Create resource header and move ANSI resource strings (http://source.winehq.org/patches/data/103118) 103119 [3/4] regsvr32: Replace all printf calls with calls to output_write; remove Silent check. (http://source.winehq.org/patches/data/103119) 103120 [4/4] regsvr32: Convert C source to Unicode (http://source.winehq.org/patches/data/103120)
Any help is appreciated.
-- Hugh McMaster
On Wed, 12 Mar 2014 02:15:46 -0400, Hugh McMaster wrote:
Was there something wrong with the following patches? I received no warnings or errors when patching and compiling one-by-one. Also, Akihiro Sagawa reviewed and passed them.
Hi, Regarding your patches, unfortunately they don't work on my environment.
Just after applying patch [1/4], gcc (4.8.1-10ubuntu9) complains about your code: gcc -c -o regsvr32.o regsvr32.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Werror regsvr32.c:80:85: error: ‘output_write’ defined but not used [-Werror=unused-function] static void __cdecl output_write(UINT id, ...) ^ cc1: all warnings being treated as errors make: *** [regsvr32.o] Error 1
Regards, Akihiro Sagawa
On Wednesday, 12 March 2014 10:14 PM, Akihiro Sagawa wrote:
Just after applying patch [1/4], gcc (4.8.1-10ubuntu9) complains about your code: gcc -c -o regsvr32.o regsvr32.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -Werror regsvr32.c:80:85: error: 'output_write' defined but not used [-Werror=unused-function] static void __cdecl output_write(UINT id, ...)
cc1: all warnings being treated as errors make: *** [regsvr32.o] Error 1
Hi Akihiro,
Many thanks for spotting this. This is what happens when I don't compile with the -Werror flag. I'll prepare a new patch sequence.
Hugh
-
Akihiro Sagawa -
Hugh McMaster