Proposal: Let Oleaut32/tests/olepicture.c faile more gracefully with missing libgif - wine-devel

3 Jul 2005

Hallo,
while I found strong opposition with my proposal to fail more gracefully
with a missing libgif, I still think the FIXME output is enough and the test
shouldn't fail, blocking any further test in a "make test" run.
To have a possible patch at least in the archive, please find it appended.
Bye
-- 
Uwe Bonnes                bon@elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Index: wine/dlls/oleaut32/tests/olepicture.c
===================================================================
RCS file: /home/wine/wine/dlls/oleaut32/tests/olepicture.c,v
retrieving revision 1.3
diff -u -r1.3 olepicture.c

--- wine/dlls/oleaut32/tests/olepicture.c	27 Jun 2005 09:57:28 -0000	1.3
+++ wine/dlls/oleaut32/tests/olepicture.c	3 Jul 2005 14:43:38 -0000
@@ -165,6 +165,11 @@

    handle = 0;
    hres = IPicture_get_Handle (pic, &handle);
+	if (hres == E_NOTIMPL) 
+	{
+	    todo_wine ok(hres == S_OK, "Probably no support for libgif/libungif, Aborting\n");
+	    return;
+	}
    ok(hres == S_OK,"IPicture_get_Handle does not return S_OK, but 0x%08lx\n", hres);
    ok(handle != 0, "IPicture_get_Handle returns a NULL handle, but it should be non NULL\n");


    