Re: Make all windows moveable by default

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> Hello,
>
> an app I'm working on creates a top level window without a caption,
> and returns HTCAPTION on WM_NCHITTEST to make the window moveable by
> dragging its client area. The app's window currently is not moveable
> under Wine because we don't set MWM_FUNC_MOVE WM hint for captionless
> windows. This patch makes my app's main window moveable.

This patch broke some full screen programs for me on KDE. Now their
caption is always visible and doesn't move off the screen. It might be
some additional magic going on with KDE to detect full-screen windows.

Vitaliy

Make all windows moveable by default

[Dmitry Timoshkov]

"Vitaliy Margolen"  wrote:
> This patch broke some full screen programs for me on KDE. Now their
> caption is always visible and doesn't move off the screen. It might be
> some additional magic going on with KDE to detect full-screen windows.

What version of KDE is it?

Do you have an url for such an app (preferably as small as possible)?

Make all windows moveable by default

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> "Vitaliy Margolen"  wrote:
> > This patch broke some full screen programs for me on KDE. Now their
> > caption is always visible and doesn't move off the screen. It might be
> > some additional magic going on with KDE to detect full-screen windows.
>
> What version of KDE is it?

This is KDE 3.5.1 from Open SuSE 10.1
> Do you have an url for such an app (preferably as small as possible)?

I can't find it anymore. This is ACDSee 3.1 trial - an old image viewer.

The problem with it is full screen image viewer mode. When I go back to
file browser and then to image viewer - I see full-screen window with
caption that is shifted down. Before this change window's caption and
borders was not visible.

Vitaliy

Make all windows moveable by default

[Dmitry Timoshkov]

"Vitaliy Margolen"  wrote:
> The problem with it is full screen image viewer mode. When I go back to
> file browser and then to image viewer - I see full-screen window with
> caption that is shifted down. Before this change window's caption and
> borders was not visible.

I observe exactly the same (not quite right) behaviour with and without
my patch: (1) picture preview is able to go correctly to full screen first
time around after pressing middle mouse button (1), all subsequent middle
mouse presses (which should switch between normal and fullscreen modes)
don't work correctly. If I go back to main screen by a left button double
click, then it all starts from the step.

Vitaliy, what are your observations?

Make all windows moveable by default

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> "Vitaliy Margolen"  wrote:
> > The problem with it is full screen image viewer mode. When I go back to
> > file browser and then to image viewer - I see full-screen window with
> > caption that is shifted down. Before this change window's caption and
> > borders was not visible.
>
> I observe exactly the same (not quite right) behaviour with and without
> my patch: (1) picture preview is able to go correctly to full screen first
> time around after pressing middle mouse button (1), all subsequent middle
> mouse presses (which should switch between normal and fullscreen modes)
> don't work correctly. If I go back to main screen by a left button double
> click, then it all starts from the step.
>
> Vitaliy, what are your observations?

- Start the program and navigate to a picture file
- Double click on the file
- If in window mode, switch to full screen (using middle button)
- While in full screen mode use middle button to switch back to file browser
- Double click picture file again

At this point with old code I had "fullscreen" window (it has visible
borders - bug introduced somewhere between 0.9.15 and 0.9.16). I can not
move this window to see if it has caption or not.
With your patch I see the the same window but shifted down so it's
caption is visible. And of course I can move it around.

Vitaliy.

Make all windows moveable by default

[Dmitry Timoshkov]

"Vitaliy Margolen"  wrote:
> - Start the program and navigate to a picture file
> - Double click on the file
> - If in window mode, switch to full screen (using middle button)
> - While in full screen mode use middle button to switch back to file browser
> - Double click picture file again
>
> At this point with old code I had "fullscreen" window (it has visible
> borders - bug introduced somewhere between 0.9.15 and 0.9.16). I can not
> move this window to see if it has caption or not.
> With your patch I see the the same window but shifted down so it's
> caption is visible. And of course I can move it around.

Although I see the caption with my patch, I think that the problem is
somewhere else: before and after my patch applied a window which is supposed
to be fullscreen, doesn't cover KDE's app bar. That most likely a bug
with WM <-> Wine interactions leading to lost fullscreen state. I tried
to investigate it, but at the moment I have no time.

Make all windows moveable by default

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> "Vitaliy Margolen"  wrote:
> > - Start the program and navigate to a picture file
> > - Double click on the file
> > - If in window mode, switch to full screen (using middle button)
> > - While in full screen mode use middle button to switch back to file
> >
> > browser
> > - Double click picture file again
> >
> > At this point with old code I had "fullscreen" window (it has visible
> > borders - bug introduced somewhere between 0.9.15 and 0.9.16). I can not

BTW this is yet one more patch of yours:

ef72c1d1002c4f9af0c9d85dee32c40144e27d2f is first bad commit
commit ef72c1d1002c4f9af0c9d85dee32c40144e27d2f
Author: Dmitry Timoshkov
Date:   Tue Jun 20 02:25:54 2006 +0900

winex11.drv: Add support for full screen window state using the NETWM
protocol.
> Although I see the caption with my patch, I think that the problem is
> somewhere else: before and after my patch applied a window which is 
> supposed to be fullscreen, doesn't cover KDE's app bar. That most

So there is a problem still. I was dealing with that by allowing other
windows to cover taskbar - works fine.

Vitaliy.

Make all windows moveable by default

[Dmitry Timoshkov]

"Vitaliy Margolen"  wrote:
> > Although I see the caption with my patch, I think that the problem is
> > somewhere else: before and after my patch applied a window which is 
> > supposed to be fullscreen, doesn't cover KDE's app bar. That most
>
> So there is a problem still. I was dealing with that by allowing other
> windows to cover taskbar - works fine.

Normal (not topmost) windows should not be able to cover a WM's app bar.
Since WS_EX_TOPMOST support is not implemented in Wine, therefore if
a window covers the WM's app bar then it's either put in a fullscreen
state by a WM, or (not 100% sure about this one) it is not managed.