Xan,
You will have to send these patches to the mailing list in separate emails. I strongly recommend using the `git send-email` command for this purpose. It would also be a good idea to ask for feedback on the #wine-staging IRC channel.
-Alex
Also, why do the From fields say that you are the author of these patches, when the actual author appears to be Jonathan Vollebregt? It would be better for Jonathan to submit these patches himself, if possible.
-Alex
From: alexhenrie24@gmail.com Date: Thu, 30 Jul 2015 01:32:17 -0600 Subject: Re: [4 PATCHES] reg.exe: implement query (bug #24017) To: xantares09@hotmail.com CC: wine-devel@winehq.org; jnvsor@gmail.com
Also, why do the From fields say that you are the author of these patches, when the actual author appears to be Jonathan Vollebregt? It would be better for Jonathan to submit these patches himself, if possible.
-Alex
Absolutely, I'll try to contact him.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-07-30 um 10:11 schrieb xantares 09:
From: alexhenrie24@gmail.com Also, why do the From fields say that you are the author of these patches, when the actual author appears to be Jonathan Vollebregt? It would be better for Jonathan to submit these patches himself, if possible.
Fwiw, the status of these patches as far as I remembered was that I ack'ed at least one of them, but Alexandre didn't commit it. My suspicion was that the patch was too big and I suggested a way to split it.
Please search through the wine-devel archives to see if you can find out what happened to those patches.
Cheers, Stefan
Responded to Xantares before I considered checking the mailing list, so I'll type the relevant bits here.
The patches he linked were from before reg had tests, and I decided to focus on getting add and delete working properly first.
The patches I submitted solved all but 1 of the (fairly extensive) tests, cleaned up the code quite a bit, and had Stefan's ack (And a lot of advice: thanks Stefan, Hugh and some others I can't remember) but after 6 months of them falling off the list I gave up.
The patches to fix add/delete and satisfy the tests are on my github [1] but I don't feel like spending another 6 months submitting them here.
I've mailed Xantares a query patch I had intended to submit after the add/delete patches were committed. If more people are interested I'll stick it on my github too.
[1]: https://github.com/jnvsor/wine/commits/reg.exe
On 07/30/2015 10:38 AM, Stefan Dösinger wrote:
Fwiw, the status of these patches as far as I remembered was that I ack'ed at least one of them, but Alexandre didn't commit it. My suspicion was that the patch was too big and I suggested a way to split it.
On 30 July 2015 at 08:42, Alex Henrie alexhenrie24@gmail.com wrote:
this purpose. It would also be a good idea to ask for feedback on the #wine-staging IRC channel.
The Wine developers IRC channel is #winehackers. #wine-staging is the IRC channel for the (hostile) wine-staging fork.
-
Alex Henrie -
Henri Verbeet -
Jonathan Vollebregt -
Stefan Dösinger -
xantares 09