Re: [PATCH] dinput: Mark internal symbols as hidden visibility

[Vitaliy Margolen]

On 05/13/2011 08:51 AM, Marcus Meissner wrote:
> -const DIDATAFORMAT c_dfDIJoystick = {
> +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick = {
> -const DIDATAFORMAT c_dfDIJoystick2 = {
> +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick2 = {
> -const DIDATAFORMAT c_dfDIMouse = {
> +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse = {
> -const DIDATAFORMAT c_dfDIMouse2 = {
> +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse2 = {
> -const DIDATAFORMAT c_dfDIKeyboard = {
> +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIKeyboard = {

These are public exports see include/dinput.h:1988.

Vitaliy.

[PATCH] dinput: Mark internal symbols as hidden visibility

[Marcus Meissner]

On Mon, May 16, 2011 at 08:26:08PM -0600, Vitaliy Margolen wrote:
> On 05/13/2011 08:51 AM, Marcus Meissner wrote:
> > -const DIDATAFORMAT c_dfDIJoystick = {
> > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick = {
> > -const DIDATAFORMAT c_dfDIJoystick2 = {
> > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick2 = {
> > -const DIDATAFORMAT c_dfDIMouse = {
> > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse = {
> > -const DIDATAFORMAT c_dfDIMouse2 = {
> > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse2 = {
> > -const DIDATAFORMAT c_dfDIKeyboard = {
> > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIKeyboard = {
>
> These are public exports see include/dinput.h:1988.

However, they are not exported via the .spec file, so they
will not get visible...

How should they be exported? Is there a static library in Windows?

Ciao, Marcus

[PATCH] dinput: Mark internal symbols as hidden visibility

[Marcus Meissner]

On Tue, May 17, 2011 at 08:51:23AM +0200, Marcus Meissner wrote:
> On Mon, May 16, 2011 at 08:26:08PM -0600, Vitaliy Margolen wrote:
> > On 05/13/2011 08:51 AM, Marcus Meissner wrote:
> > > -const DIDATAFORMAT c_dfDIJoystick = {
> > > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick = {
> > > -const DIDATAFORMAT c_dfDIJoystick2 = {
> > > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIJoystick2 = {
> > > -const DIDATAFORMAT c_dfDIMouse = {
> > > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse = {
> > > -const DIDATAFORMAT c_dfDIMouse2 = {
> > > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIMouse2 = {
> > > -const DIDATAFORMAT c_dfDIKeyboard = {
> > > +DECLSPEC_HIDDEN const DIDATAFORMAT c_dfDIKeyboard = {
> >
> > These are public exports see include/dinput.h:1988.
>
> However, they are not exported via the .spec file, so they
> will not get visible...
>
> How should they be exported? Is there a static library in Windows?

I looked at this, and it should be:

dinput.h should define the GUIDs when #define INITGUID is set.

The export should be from dxguid.lib (this will automatically work
once the defines are moved to dinput.h)

Ciao, Marcus