So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin.
It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues.
I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5).
For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone.
One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped.
As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables.
I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin.
- Kyle
Hi Kyle,
Thanks for the update, and sorry for the late reply!
I've actually deployed your theme to production already: http://wiki.winehq.org
My only change was this:
diff --git a/winewiki.conf b/winewiki.conf index 4e79248..e3da9cc 100644 --- a/winewiki.conf +++ b/winewiki.conf @@ -8,7 +8,8 @@ #RewriteLog "/var/log/httpd/rewrite.log" # map some static files to their respective locations RewriteRule ^/favicon.ico$ /var/www/wine/wiki/favicon.ico [last] - RewriteRule ^/logo.png$ /var/www/wine/wiki/logo.png [last] + RewriteRule ^/logo_glass.png$ /var/www/wine/wiki/logo_glass.png [last] + RewriteRule ^/logo_text.png$ /var/www/wine/wiki/logo_text.png [last] # map /wiki static files to Moin htdocs RewriteRule ^/wiki/(.*)$ /usr/share/moin/htdocs/$1 [last] # map everything else to server script
Dimi.
On Sat, Mar 30, 2013 at 5:08 PM, Kyle Auble randomidman48@yahoo.com wrote:
So as usual, my estimate of how long it would take was way off, but I'm finally done adapting the WineHQ theme to Moinmoin.
It's not perfect, but I feel it's ready to submit for switching over. I've tested it in Firefox, Chromium, Midori, and Opera (briefly in IE8 & IE9 too). I did do everything through Moinmoin's stand-alone server, but while I know there always seem to be ghosts in the machine, I'm guessing that Apache shouldn't interfere with layout issues.
I mostly followed the WineHQ & current WineWiki theme for large things, just tweaking the CSS to make it fit what Moinmoin spits out. I did make more design choices of my own on the smaller stuff though. After wrestling with Moinmoin's theme system, I was surprised how many things are still hard-coded (at least as of v1.5).
For example, Moinmoin wraps some things in divs without providing a CSS class for the div, just the child element. The fortune cookie on the RecentChanges page & the edit page are two cases of that. The dummy content in the search bar is another tricky one. It's set in the javascript for the search bar (don't remember where it was in the source tree) so I left that one alone.
One other tricky issue was handling overflows & RTL support. They both seem to work ok in isolation, but go crazy when you mix them. I haven't checked RTL in IE, but if you force an RTL page to overflow in Webkit, it positions things based on what's actually in the window (so the sidebar winds up floating in the middle of the page). Firefox simply doesn't try to apply any of the overflow rules in RTL (which I guess is nice in a Hippocratic sense). Opera alone handled things exactly like I hoped.
As for the tables, I think they should display ok now, although I don't know if everyone wants my exact values for paddings & such. The old theme had some table-based layout that may have had conflicting CSS rules, but I've div-vied everything up so the only table tags now should be when Moinmoin itself chooses them over a div and well... tables.
I've pushed all of the changes to my Bitbucket repo at: https://bitbucket.org/kauble/wine-wiki-migration The "refined" branch is the one you want although I expect that once the code is hosted at WineHQ's git repo, it would become the new master branch. At that point, I can just reset my repo to point to the WineHQ one as the origin.
- Kyle
On Sat, Apr 6, 2013 at 5:14 PM, Dimi Paun wrote:
I've actually deployed your theme to production already: http://wiki.winehq.org
My only change was this:
diff --git a/winewiki.conf b/winewiki.conf index 4e79248..e3da9cc 100644 --- a/winewiki.conf +++ b/winewiki.conf @@ -8,7 +8,8 @@ #RewriteLog "/var/log/httpd/rewrite.log" # map some static files to their respective locations RewriteRule ^/favicon.ico$ /var/www/wine/wiki/favicon.ico [last]
- RewriteRule ^/logo.png$ /var/www/wine/wiki/logo.png [last]
- RewriteRule ^/logo_glass.png$ /var/www/wine/wiki/logo_glass.png [last]
- RewriteRule ^/logo_text.png$ /var/www/wine/wiki/logo_text.png [last]
# map /wiki static files to Moin htdocs RewriteRule ^/wiki/(.*)$ /usr/share/moin/htdocs/$1 [last] # map everything else to server script
Oh, cool! Don't worry about taking time to reply, I know when people are busy it's good to follow up just now and then. I'm looking at it right now on some of the computers in my apartment's business office & it does seem to be causing IE 8 & 9 some problems. One of them has Firefox 3 though (they go a while without updates), and even for that old version, there are only a few issues I can see. I'll get my laptop out in a little bit to check it on newer versions of the major browsers, and over the next few days, I'll try to iron out any IE issues and last wrinkles. After that, I guess the next order of business will be to see about moving the repo onto WineHQ. - Kyle
Am 07.04.2013 03:59, schrieb Kyle Auble:
On Sat, Apr 6, 2013 at 5:14 PM, Dimi Paun wrote:
I've actually deployed your theme to production already: http://wiki.winehq.org
Oh, cool!
Don't worry about taking time to reply, I know when people are busy it's good to follow up just now and then. I'm looking at it right now on some of the computers in my apartment's business office & it does seem to be causing IE 8 & 9 some problems.
One of them has Firefox 3 though (they go a while without updates), and even for that old version, there are only a few issues I can see. I'll get my laptop out in a little bit to check it on newer versions of the major browsers, and over the next few days, I'll try to iron out any IE issues and last wrinkles.
After that, I guess the next order of business will be to see about moving the repo onto WineHQ.
First: Wow! You did a great job! Finally our Wiki theme is up to date :) I had a look at some Pages already and they look perfect here with FF 20.0 What i wonder is how we want to proceed with tables, i've seen different tables already and we should maybe choose one style: http://wiki.winehq.org/FOSDEM2013 http://wiki.winehq.org/Gecko <- Here we used a workaround for the missing boarders and spacing http://wiki.winehq.org/Recommended_Packages <- strange HTML http://wiki.winehq.org/Portability
On Sun, Apr 7, 2013 at 8:43 AM, André Hentschel wrote:
First: Wow! You did a great job! Finally our Wiki theme is up to date :) I had a look at some Pages already and they look perfect here with FF 20.0 What i wonder is how we want to proceed with tables, i've seen different tables already and we should maybe choose one style: http://wiki.winehq.org/FOSDEM2013 http://wiki.winehq.org/Gecko <- Here we used a workaround for the missing boarders and spacing http://wiki.winehq.org/Recommended_Packages <- strange HTML http://wiki.winehq.org/Portability
Thank you for the compliment! I just pushed Dimi's changes (I reset the author flag to him & used the time of his email for the date) and my own last set of changes to my repo. If everyone wants, we could probably put the upstream repo on WineHQ now.
After a bit more testing, I was actually able to figure out the other problems. The overflow issue was coming from a subtlety with absolutely positioned elements (if no explicitly positioned container exists, the container defaults to the browser window, not the page). I also fixed the problem where any link in a message box was being rendered like the "clear" button.
The other funky rendering I was seeing actually has nothing to do with IE or the CSS. I forgot but Moin 1.5 doesn't spit out strict HTML4 so my browsers were defaulting to quirks mode. I guess the standalone server injects a doctype declaration though, which is why I wasn't seeing the problems in testing. Those problems should go away once upgrading to Moin 1.9.
And regarding the tables, I'm cool with whatever style everyone agrees on, but I don't know how everyone feels about setting styles in the wiki- markup. Moin (1.5 at least) doesn't use <th> elements so I created a custom CSS class for <tr> elements called "heading." It just makes the text heavier in print view, but on screen, it's like a heading row on the other pages, only with a wine-red background instead of black.
- Kyle
-
André Hentschel -
Dimi Paun -
Kyle Auble