iTunes 7

[Juan Lang]

Folks, I just sent a series of wintrust patches that gets iTunes 7 to
start, at least for me.  I expect some will get rejected due to
collision with Francois's patch - I'll resynch and resend.  But if you
want to play around with iTunes, grab those patches and give them a
whirl.

Known issues:
1. Your screen will go black when it starts.  This is something
QuickTime is doing.  You can drag windows around to force some
repainting to work around it.
2. You'll see lots of fixmes on the console, especially:
"fixme:setupapi:CMP_WaitNoPendingInstallEvents 0",
"fixme:setupapi:SetupDiGetClassDevsW returning empty list", and
"fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled."
3. The main window will be transparent (and basically unusable) if you
don't have GL support compiled in.

Have fun,
--Juan

[Scott Ritchie]

Juan Lang wrote:
> Folks, I just sent a series of wintrust patches that gets iTunes 7 to
> start, at least for me.  I expect some will get rejected due to
> collision with Francois's patch - I'll resynch and resend.  But if you
> want to play around with iTunes, grab those patches and give them a
> whirl.
>
> Known issues:
> - Your screen will go black when it starts.  This is something
>
> QuickTime is doing.  You can drag windows around to force some
> repainting to work around it.
> 2. You'll see lots of fixmes on the console, especially:
> "fixme:setupapi:CMP_WaitNoPendingInstallEvents 0",
> "fixme:setupapi:SetupDiGetClassDevsW returning empty list", and
> "fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled."
> 3. The main window will be transparent (and basically unusable) if you
> don't have GL support compiled in.
>
> Have fun,
> --Juan

You are amazing.  If iTunes 7 can be made to work by 0.9.45 (or 0.9.46),
it can make it into Ubuntu Gutsy.  Seeing as how iTunes is consistently
one of our top 5 demanded apps, the improvement from the user's
perspective will be palpable.

Combined with everything else the team has been doing lately, I can just
see the buzz: "Wow, Wine really is improving quickly and starting to
"just work."

Thanks,
Scott Ritchie

[Juan Lang]

> You are amazing.

Thank Dan Kegel and Google for sponsoring me to work on it this
summer.  Luckily for me, it's ended up being almost exactly one
summer's worth of work.
> If iTunes 7 can be made to work by 0.9.45 (or 0.9.46),
> it can make it into Ubuntu Gutsy.  Seeing as how iTunes is consistently
> one of our top 5 demanded apps, the improvement from the user's
> perspective will be palpable.

Maybe so!  So, some testing would be great.  There are some bugs
there, like, scrolling in the Music store is very slow (that's already
logged.)  I have no idea of syncing with your iPod works - I keep
forgetting to bring mine in to test it.

So, let's see how close to working this really is, huh?
--Juan

[Markus Amsler]

Juan Lang wrote:
> Folks, I just sent a series of wintrust patches that gets iTunes 7 to
> start, at least for me.  I expect some will get rejected due to
> collision with Francois's patch - I'll resynch and resend.  But if you
> want to play around with iTunes, grab those patches and give them a
> whirl.
>
> Known issues:
> - Your screen will go black when it starts.  This is something
>
> QuickTime is doing.  You can drag windows around to force some
> repainting to work around it

Just a wild guess, does the attached patch fix the problem? Battlefield 
1942 shows the  same behavior in windowed mode.

[Stefan Dösinger]

Am Mittwoch, 12. September 2007 04:37:51 schrieb Markus Amsler:
> Juan Lang wrote:
> > Folks, I just sent a series of wintrust patches that gets iTunes 7 to
> > start, at least for me.  I expect some will get rejected due to
> > collision with Francois's patch - I'll resynch and resend.  But if you
> > want to play around with iTunes, grab those patches and give them a
> > whirl.
> >
> > Known issues:
> > - Your screen will go black when it starts.  This is something
> >
> > QuickTime is doing.  You can drag windows around to force some
> > repainting to work around it
>
> Just a wild guess, does the attached patch fix the problem? Battlefield
> 1942 shows the  same behavior in windowed mode.

The problem with QuickTime is that it does a LockRect() on the front buffer, 
which draws on the NULL window without a clipper set. The GetDC call you're 
removing here causes a simmilar issue(it also leads to a LockRect). WineD3D's 
gdi surfaces write to the destination window, but they do not read from it. A 
quick test shows that locking the primary returns the contents of the screen 
so we should propably read the destination window's contents if we're locking 
the front buffer, but AJ objected against that and I didn't put much effort 
in getting this patch in.

However, you make a good point that wined3d inherently has that problem, due 
to these GetDC() and ReleaseDC(). We use them to make the surface code create 
a DIB section for the surface.

[Juan Lang]

> Just a wild guess, does the attached patch fix the problem? Battlefield
> 1942 shows the  same behavior in windowed mode.

Thanks for suggesting a fix, but that doesn't fix the problem.
--Juan