2016-06-15 9:51 GMT+02:00 Paul Gofman gofmanp@gmail.com:
Hello Matteo,
I am afraid that if application passes effect data broken anarbitrary way then probably almost every ERR and FIXME should be changed to WARN (at least in my code, but probably in the rest of effect framework either). E. g., we have FIXME on not yet supported relative addressing, but it can also happen if the application passes broken effect code. Or do you see any difference for this case with parameter name? I do not yet, as actually preshader and effect are compiled together, and it is no way to get such a situation (at least if there is some feature in fxc compiler which I am not aware of) other than modifying effect bytecode.
Regards, Paul.
The general idea is that FIXME refers to something that isn't (completely / correctly) implemented in Wine, so e.g. FIXME is the right choice for relative addressing. ERR is the correct choice for "internal errors" in Wine (i.e. something that shouldn't happen unless there is a bug in Wine - the ERR("Unexpected register set %u.\n", ...) is a good example of that) and WARN should be used when the application can trigger the problematic condition by misusing the API or similar.
Specifically WRT this patch I just happened to notice that ERR while looking through the code and it seems to me that WARN fits better. It's not a big deal either way.
-
Matteo Bruni