Re: [Patch 1/2] winecfg: Set default button in Libraries tab [fixes bug 12804]

[André Hentschel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 24.06.2014 10:35, schrieb Hugh McMaster:
> This patch sets the default button to IDC_DLLS_ADDDLL in the Libraries tab of winecfg when a user is typing in the combo box.
>
> This allows the user to hit the Enter key and add the override. Currently, hitting the Enter key closes winecfg, which is causing problems with many users.
>
> The patch fixes bug 12804 and was tested by Austin English.

That's just a workaround, if you modify winecfg to run on Windows you'll see that the button works there as expected, the problem lies deeper in the Wine code...
Of course we maybe want a workaround to satisfy our users...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQGcBAEBAgAGBQJTqdjyAAoJEGm5GZTakYsswH4L/198JPSwjgYiwSnLkYgBjZJ6
YD5XWVA3YfdexdV2urNIIN8fHv97xVR9INqnbEksS/HJpTY9QU9CIYTSw8IkxlS4
3423KKJe+St7cjKLwoAMFK6LJNQrtloxik2S8Y7y7QMLocPxmRPZOFK45032RTEM
BH/vAwxtud4yux13rKsl9TX4Z6LwoqeKcGk9k0I2vYy0ez53rIS0bP9sytasNTLL
34Vmj65kVX5lQGYNhECgkd5W2LNDSUxXecpc+BQ1iaHNNnGkne0uZPERVoqIRHYv
TZuhtzF/VI4nXO9bRnAkZhMycHH8aZI4vk5D/kvamzEApDx8dC78S+s0by+RFLfb
7UMaV24GM6DI3QS6aK7e/UjTSBKq4fqyOykrn0Pdjhb7fx5OPHevV84HoPil5Sx0
LRsrNZQY+tr+0jqHvAV0YPohspZb05qZDQbv/6jnt085m6SIQdPiJq4RqD6Vwl81
cpy1fYd1hTO1hY5zSrVl+6TbN9PgniTb6d5OfhI5+g==
=Z18S
-----END PGP SIGNATURE-----

[Patch 1/2] winecfg: Set default button in Libraries tab [fixes bug 12804]

[Hugh McMaster]

On Wednesday, 25 June 2014 6:01 AM, André Hentschel wrote:
> Am 24.06.2014 10:35, schrieb Hugh McMaster:
> > This patch sets the default button to IDC_DLLS_ADDDLL in the Libraries tab
> > of winecfg when a user is typing in the combo box.
> >
> > This allows the user to hit the Enter key and add the override. Currently,
> > hitting the Enter key closes winecfg, which is causing problems with many
> > users.
>
> That's just a workaround, if you modify winecfg to run on Windows you'll see
> that the button works there as expected, the problem lies deeper in the
> Wine code...

What's the best way to modify winecfg? I've stripped almost everything from libraries.c and main.c, and I'm compiling these two files with i686-w64-mingw32-gcc . The dialog doesn't appear on Windows though.

Do you mean the Add button works on Windows with the call SendMessageW(GetParent(dialog), DM_SETDEFID, IDC_DLLS_ADDDLL, 0);? Or does it work without the GetParent(dialog) call?
> Of course we maybe want a workaround to satisfy our users...

The bug was reported over six years ago and the problem is apparently confusing/frustrating a lot of people. It's not a perfect solution by any means... but it is up to Alexandre Julliard to decide what to do.

[Patch 1/2] winecfg: Set default button in Libraries tab [fixes bug 12804]

[Hugh McMaster]

On Wednesday, 25 June 2014 6:01 AM, André Hentschel wrote:
> Am 24.06.2014 10:35, schrieb Hugh McMaster:
> > This patch sets the default button to IDC_DLLS_ADDDLL in the Libraries tab
>
> of winecfg when a user is typing in the combo box.
> > This allows the user to hit the Enter key and add the override. Currently,
>
> hitting the Enter key closes winecfg, which is causing problems with many
> users.
> > The patch fixes bug 12804 and was tested by Austin English.
>
> That's just a workaround, if you modify winecfg to run on Windows you'll see
> that the button works there as expected, the problem lies deeper in the
> Wine code...

Confirmed. I'll keep looking.