Hello,
I'd like to get rid of tabs I encounter when reading existing Wine code.
Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches.
Saulius Krasuckas saulius2@ar.fi.lt writes:
Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches.
No, please don't do that.
* On Tue, 8 Nov 2005, Alexandre Julliard wrote:
- Saulius Krasuckas saulius2@ar.fi.lt writes:
Will my patches be let into the tree if I will submit such no-op changes (one patch for one file) from time to time just before normal, operational patches.
No, please don't do that.
OK, and what tab size should I assume when I see it in simple one level indent -- 4 or 8 space characters?
"Saulius Krasuckas" saulius2@ar.fi.lt wrote:
OK, and what tab size should I assume when I see it in simple one level indent -- 4 or 8 space characters?
Tab is 8 characters by definition.
* On Tue, 8 Nov 2005, Dmitry Timoshkov wrote:
- "Saulius Krasuckas" saulius2@ar.fi.lt wrote:
OK, and what tab size should I assume when I see it in simple one level indent -- 4 or 8 space characters?
Tab is 8 characters by definition.
The question isn't about world wide definition, it's about preference inside Wine project. But OK, I will use tabs in a tabby files.
Saulius Krasuckas wrote:
The question isn't about world wide definition, it's about preference inside Wine project. But OK, I will use tabs in a tabby files.
Please use spaces, we can't get rid of existing tabs but let's not make things worse.
Ivan.
* On Wed, 9 Nov 2005, Ivan Leo Puoti wrote:
- Saulius Krasuckas wrote:
The question isn't about world wide definition, it's about preference inside Wine project. But OK, I will use tabs in a tabby files.
Please use spaces, we can't get rid of existing tabs but let's not make things worse.
No I won't, because then a diff in my editor looks wrong.
Saulius Krasuckas wrote:
- On Wed, 9 Nov 2005, Ivan Leo Puoti wrote:
- Saulius Krasuckas wrote:
The question isn't about world wide definition, it's about preference inside Wine project. But OK, I will use tabs in a tabby files.
Please use spaces, we can't get rid of existing tabs but let's not make things worse.
No I won't, because then a diff in my editor looks wrong.
You can fix your editor settings, and anyway the patch will look right once you apply it.
Ivan.
From: "Saulius Krasuckas" saulius2@ar.fi.lt
No I won't, because then a diff in my editor looks wrong.
This is a bit confusing at first because diff inserts a char at the beginning of the line. Don't worry about it, the source will look right after applying it. You will get used to it soon enough :)
* On Thu, 10 Nov 2005, Dimi Paun wrote:
- From: "Saulius Krasuckas" saulius2@ar.fi.lt
No I won't, because then a diff in my editor looks wrong.
This is a bit confusing at first because diff inserts a char at the beginning of the line.
Of course I understand this. I just don't like "elastic" tabs. :-/ Can they be made "solid" in vim easily?
Don't worry about it, the source will look right after applying it. You will get used to it soon enough :)
Hm, I didn't get during one year and I doubt I will. That's just my brain lacking, lets say, processing bandwidth for one additional and temporary filtering task. Because of this I get unaesthetic feeling and just lose my interest in checking the patch or even writing more code. :-|
-
Alexandre Julliard -
Dimi Paun -
Dmitry Timoshkov -
Ivan Leo Puoti -
Saulius Krasuckas