Re: MSI: free allocated buffers

[Joris Huizer]

Mike McCormack wrote:
> ChangeLog:
> - free allocated buffers

The other daty I saw a lot of patches changing things like
   if (buffer)
     HeapFree(GetProcessHeap(),0,buffer);
To
   HeapFree(GetProcessHeap(),0,buffer);

Why are you adding new code with the if() statement in place again?

Just curious

regards,

Joris

MSI: free allocated buffers

[Mike McCormack]

Joris Huizer wrote:
> The other daty I saw a lot of patches changing things like
>   if (buffer)
>     HeapFree(GetProcessHeap(),0,buffer);
> To
>   HeapFree(GetProcessHeap(),0,buffer);
>
> Why are you adding new code with the if() statement in place again?

Note all these patches were written by Aric, and I mostly didn't modify 
them before sending them.  When they're all applied and synch'ed up with 
what we have internally (which is almost the case), I'll start fixing up 
the problems that merging them has caused... unless they're rejected 
first ;)

Mike

MSI: free allocated buffers

[Michael Stefaniuc]

Joris Huizer wrote:
> Mike McCormack wrote:
> > ChangeLog:
> > - free allocated buffers
>
> The other daty I saw a lot of patches changing things like
>   if (buffer)
>     HeapFree(GetProcessHeap(),0,buffer);
> To
>   HeapFree(GetProcessHeap(),0,buffer);
>
> Why are you adding new code with the if() statement in place again?

Alexandre didn't accepted my patch for the msi dll. I think he is 
waiting for the finishing of the msi merging. I'll have to redo the 
patch then anyway because it already conflicts to actual cvs.

bye
    michael