Re: apphelp: add a stub for SdbInitDatabase (try 2)

[Dmitry Timoshkov]

Austin English  wrote:
> - if (path)
> -
>    FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please report!\n", flags, debugstr_w(path));
> - else
> -
>    FIXME("stub: %08x %s\n", flags, debugstr_w(path));

What's the reason for this if/else? What exactly is not expected and why
this matters for a stub?

apphelp: add a stub for SdbInitDatabase (try 2)

[Austin English]

On Wed, Apr 2, 2014 at 12:25 AM, Dmitry Timoshkov  wrote:
> Austin English  wrote:
> > - if (path)
> > -
> >    FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please
>
> report!\n", flags, debugstr_w(path));
> > - else
> > -
> >    FIXME("stub: %08x %s\n", flags, debugstr_w(path));
>
> What's the reason for this if/else? What exactly is not expected and why
> this matters for a stub?
>
> --
> Dmitry.

It's expected to be NULL in practice, I thought it would be helpful for
Focht to easily spot future applications that are using this API.

It's not necessary for the stub, of course. I can remove and resend if
necessary, but I don't think that it is.

apphelp: add a stub for SdbInitDatabase (try 2)

[Dmitry Timoshkov]

Austin English  wrote:
> > > - if (path)
> > > -
> > >    FIXME("stub: flags: %08x, path: \"%s\". Unexpected, please
> >
> > report!\n", flags, debugstr_w(path));
> > > - else
> > > -
> > >    FIXME("stub: %08x %s\n", flags, debugstr_w(path));
> >
> > What's the reason for this if/else? What exactly is not expected and why
> > this matters for a stub?
> >
> > --
> > Dmitry.
>
> It's expected to be NULL in practice,

Why do you think that it's expected to be NULL?
> I thought it would be helpful for
> Focht to easily spot future applications that are using this API.

Isn't printing a FIXME enough for that?