re: Ok guys...

[Dan Kegel]

Your subject line was confusing; what's this about?

Your patches seem malformed, they come across with
question marks for tabs, e.g.

--- context.c??? 2008-06-26 13:52:57.000000000 -0400
+++ context.c.patch1??? 2008-06-26 15:19:15.000000000 -0400
@@ -145,9 +145,7 @@ static int WineD3D_ChoosePixelFormat(IWi
?
???? DepthStencilFormat = WINED3DFMT_D24S8;
?
-??? if(DepthStencilFormat) {
-??????? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);
-??? }
+??? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);

Perhaps you should resend, using a proper subject line,
attaching one patch per message, and providing a good
description of what each patch does.

If you expect the patches to be applied, they
need to go to wine-patches, not wine-devel.

Ok guys...

[Reece Dunn]

2008/6/26 Dan Kegel :
> Your subject line was confusing; what's this about?
>
> Your patches seem malformed, they come across with
> question marks for tabs, e.g.

They look fine on my googlemail account :), and it looks like they are
spaces, not tabs.
> --- context.c??? 2008-06-26 13:52:57.000000000 -0400
> +++ context.c.patch1??? 2008-06-26 15:19:15.000000000 -0400
> @@ -145,9 +145,7 @@ static int WineD3D_ChoosePixelFormat(IWi
> ?
> ???? DepthStencilFormat = WINED3DFMT_D24S8;
> ?
> -??? if(DepthStencilFormat) {
> -??????? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);
> -??? }
> +??? getDepthStencilBits(DepthStencilFormat, &depthBits, &stencilBits);

Is this an encoding issue due to a non-0x20 space being used (e.g. the
non-breaking whitespace 0xA0)?
> If you expect the patches to be applied, they
> need to go to wine-patches, not wine-devel.

As has been said before, the developer is trying to get feedback
before sending the patches there.

- Reece

Ok guys...

[Dan Kegel]

On Thu, Jun 26, 2008 at 2:11 PM, Reece Dunn  wrote:
> 2008/6/26 Dan Kegel :
> > Your subject line was confusing; what's this about?

Celticht32, please don't change the subject line when replying.
It makes it very hard to follow the thread.
And please use a descriptive subject line; this isn't a forum,
it's a mailing list, and the rules are different.

Ok guys...

[Stefan Dösinger]

> If you expect the patches to be applied, they
> need to go to wine-patches, not wine-devel.

I think he doesn't want them to be applied, he's hunting a bug in some app
and these patches happen to work around some problems. So they are a start
for further discussion/debugging, but as such they are not correct.

Roderick, do you have any idea?