Re: DirectPlay should initialize The session guid when creating a session

[Tomas Carnecky]

Alessandro Pignotti wrote:
> Hi, 
> this is my first patch i hope it's well formatted

formating is good.
> From Microsoft DirectX SDK Documentation it seems that directplay should 
> initialize the instance guid on session creation, this trivial patch does 
> that.

Two questions:

1. Does windows do this, too? You can't rely on the MS SDK
Documentation, always look what windows does and do it likewise. In many
cases, a wine test should be written to verify the behavior.

2. Does it solve anything? A bug, a problem with an application?

tom

DirectPlay should initialize The session guid when creating a session

[Kai Blin]

On Sunday 28 January 2007 20:38, Tomas Carnecky wrote:
> > From Microsoft DirectX SDK Documentation it seems that directplay should
> > initialize the instance guid on session creation, this trivial patch does
> > that.
>
> Two questions:
> - Does windows do this, too? You can't rely on the MS SDK
>
> Documentation, always look what windows does and do it likewise. In many
> cases, a wine test should be written to verify the behavior.
> - Does it solve anything? A bug, a problem with an application?

Right now, it doesn't, as Wine doesn't _have_ a working DirectPlay 
implementation. However, Alessandro contacted me some time ago and was 
interested in starting to implement it. As I'm still busy working on figuring 
out the wire protocol used for dplay, I didn't get around to look at the 
programming side of things much.

Alex, what are you currently trying to do? I figure it would make sense to 
kill the needed dll overrides for dplay dlls one by one, dplayx.dll might be 
a good start to do so.

I'll be happy to help you with writing a test case for your current patch.

Cheers,
Kai

DirectPlay should initialize The session guid when creating a session

[Alessandro Pignotti]

On Monday 29 January 2007 14:26, Kai Blin wrote:
> On Sunday 28 January 2007 20:38, Tomas Carnecky wrote:
> > > From Microsoft DirectX SDK Documentation it seems that directplay
> > > should initialize the instance guid on session creation, this trivial
> > > patch does that.
> >
> > Two questions:
> > - Does windows do this, too? You can't rely on the MS SDK
> >
> > Documentation, always look what windows does and do it likewise. In many
> > cases, a wine test should be written to verify the behavior.
> > - Does it solve anything? A bug, a problem with an application?
>
> Right now, it doesn't, as Wine doesn't _have_ a working DirectPlay
> implementation. However, Alessandro contacted me some time ago and was
> interested in starting to implement it. As I'm still busy working on
> figuring out the wire protocol used for dplay, I didn't get around to look
> at the programming side of things much.
>
> Alex, what are you currently trying to do? I figure it would make sense to
> kill the needed dll overrides for dplay dlls one by one, dplayx.dll might
> be a good start to do so.
>
> I'll be happy to help you with writing a test case for your current patch.
>
> Cheers,
> Kai

I'm now trying to get my dpwsock.dll to work with native dplayx to figure out 
how the service provider implementation is expected to receive session data.
Thanks a lot
Bye