Re: [PATCH] msvcr120: Implement more C99 math functions.

[Piotr Caban]

On 12/06/14 17:07, Martin Storsjo wrote:
> +/*********************************************************************
> -
> -
>  cbrt (MSVCR120.@)
> - */
>
> +double CDECL MSVCR120_cbrt(double x)
> +{
> +#ifdef HAVE_CBRT
> - return cbrt(x);
>
> +#else
> - return x < 0 ? -powf(-x, 1.0 / 3.0) : powf(x, 1.0 / 3.0);
>
> +#endif

Please use pow instead of powf here.

Thanks,
Piotr

[PATCH] msvcr120: Implement more C99 math functions.

[Martin Storsjö]

On Mon, 8 Dec 2014, Piotr Caban wrote:
> On 12/06/14 17:07, Martin Storsjo wrote:
> > +/*********************************************************************
> > -
> > -
> >  cbrt (MSVCR120.@)
> > - */
> >
> > +double CDECL MSVCR120_cbrt(double x)
> > +{
> > +#ifdef HAVE_CBRT
> > - return cbrt(x);
> >
> > +#else
> > - return x < 0 ? -powf(-x, 1.0 / 3.0) : powf(x, 1.0 / 3.0);
> >
> > +#endif
>
> Please use pow instead of powf here.

Oh, indeed, thanks for catching.

// Martin