Re: [2/4] msvcp120/tests: Add 64bit and arm's initialization of xtime functions.

[Nikolay Sivov]

On 17.03.2015 18:41, YongHao Hu wrote:
> - if(sizeof(void*) == 8) { /* 64-bit initialization */
> -
>    SET(p__Xtime_diff_to_millis2,
> -
>            "_Xtime_diff_to_millis2");
> -
>    SET(p_xtime_get,
> -
>            "xtime_get");
> - } else {
>
> +#ifdef __arm__
> -
>    SET(p__Xtime_diff_to_millis2,
> -
>            "_Xtime_diff_to_millis2");
> -
>    SET(p_xtime_get,
> -
>            "xtime_get");
>
> +#else
> -
>    SET(p__Xtime_diff_to_millis2,
> -
>            "_Xtime_diff_to_millis2");
> -
>    SET(p_xtime_get,
> -
>            "xtime_get");
>
> +#endif

Why do you need this if export name is always the same?

[2/4] msvcp120/tests: Add 64bit and arm's initialization of xtime functions.

[YongHao Hu]

Yeah, I don't need it.
I shouldn't change it because I just need the 64bit and 32bit 
initialization in the test of functions from tr2 namespace.
Thank you for the comment.

On 2015年03月18日 01:13, Nikolay Sivov wrote:
> On 17.03.2015 18:41, YongHao Hu wrote:
> > - if(sizeof(void*) == 8) { /* 64-bit initialization */
> > -
> >    SET(p__Xtime_diff_to_millis2,
> > -
> >            "_Xtime_diff_to_millis2");
> > -
> >    SET(p_xtime_get,
> > -
> >            "xtime_get");
> > - } else {
> >
> > +#ifdef __arm__
> > -
> >    SET(p__Xtime_diff_to_millis2,
> > -
> >            "_Xtime_diff_to_millis2");
> > -
> >    SET(p_xtime_get,
> > -
> >            "xtime_get");
> >
> > +#else
> > -
> >    SET(p__Xtime_diff_to_millis2,
> > -
> >            "_Xtime_diff_to_millis2");
> > -
> >    SET(p_xtime_get,
> > -
> >            "xtime_get");
> >
> > +#endif
>
> Why do you need this if export name is always the same?