On 24.08.2016 19:05, Marvin wrote:
Thank you for your contribution to Wine!
This is an automated notification to let you know that your patch has been reviewed and its status set to "Pending".
This means that the patch is not necessarily wrong, but its correctness is not obvious. You should either write a test case demonstrating that it is correct, try to fix the problem in a more straightforward way, or better explain why you are doing things this way.
If you do not understand the reason for this status, disagree with our assessment, or are simply not sure how to proceed next, please ask for clarification by replying to this email.
It's not clear to me why this was set to pending, so I'll try to cover most bases in this mail:
I assume the patch itself is fine!? We deploy it on every arch (Linux: amd64 arm64 armel armhf i386 powerpc, hurd-i386, kfreebsd-i386)
Authorship: The original author Mike (CCed in patch submission) is quite short on time, so I decided to bring this patch (and others that we have in Debian) here. The whole Debian packaging is LGPL-2.1+ licensed (except if we use 3rd party stuff, which isn't the case for this patch). See [1].
History of this patch: 1.7.45-1 add, Michael Gilbert [2] 1.7.54-1 temporarily disable, Michael Gilbert [3] 1.7.54-2 refresh and readd, Michael Gilbert [4] 1.7.55-1 rename, Michael Gilbert [5] 1.9.9-1 refresh, Jens Reyer [6]
Is this patch needed?
Related (fixed) build failures: The last successful build on kfreebsd-i386 without this patch was 1.7.41-1. There's no data for 1.7.42/1.7.43. 1.7.44 failed to build. With the patch 1.7.45 and following versions built. When the patch was removed temporarily 1.7.54-1 failed to build. Later versions with patch built again. A list of all build logs is available at [7].
I didn't run a regression test, nor can name the relevant commit that caused the failure (I assume it was a change in Wine).
If required I might verify if the patch is still needed today, but I'd have to apply for access to a kfreebsd machine first.
I hope this clarifies everything Greets jre
[1] https://anonscm.debian.org/git/pkg-wine/wine.git/tree/debian/copyright
[2] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=4d7a55e
[3] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=94643f4
[4] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=0fa1339
[5] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=8deb56f
[6] https://anonscm.debian.org/git/pkg-wine/wine.git/commit/?id=3d3f870
[7] https://buildd.debian.org/status/logs.php?pkg=wine-development&arch=kfre...
On 25.08.2016 13:32, Jens Reyer wrote:
On 24.08.2016 19:05, Marvin wrote:
Thank you for your contribution to Wine!
This is an automated notification to let you know that your patch has been reviewed and its status set to "Pending".
This means that the patch is not necessarily wrong, but its correctness is not obvious. You should either write a test case demonstrating that it is correct, try to fix the problem in a more straightforward way, or better explain why you are doing things this way.
If you do not understand the reason for this status, disagree with our assessment, or are simply not sure how to proceed next, please ask for clarification by replying to this email.
It's not clear to me why this was set to pending, so I'll try to cover most bases in this mail:
I saw you committed it yesterday, conditionally only if we have the header file. I'll keep that in mind.
Thanks a lot!
-
Jens Reyer