tools/winemaker prints unexpected output

[Saulius Krasuckas]

Now I am running it on a latest GIT tree this way:

$ tools/winapi/msvcmaker --no-wine
 .: searching for /^Makefile.in$/

And after a while it appends this string to the end of last line:

readline() on closed filehandle IN at tools/winapi/msvcmaker line 134.

Maybe it doesn't indicate any harm, but in ideal world this should be 
fixed.  I don't know perl, unfortunately.

[PATCH] Re: tools/winemaker prints unexpected output

[Colin Pitrat]

Hi,
it seems like the open function failed, but the error code wasn't 
checked, resulting in a wrong filehandle. I think I would correct it 
this way (see attached patch).

Regards,

Colin Pitrat (Bull Services Telco)
Bull,  Architect of an Open World (TM)
Tél : +33 (0)  1 30 80 72 93
www.bull.com

Saulius Krasuckas wrote:
> Now I am running it on a latest GIT tree this way:
>
> $ tools/winapi/msvcmaker --no-wine
>  .: searching for /^Makefile.in$/
>
> And after a while it appends this string to the end of last line:
>
> readline() on closed filehandle IN at tools/winapi/msvcmaker line 134.
>
> Maybe it doesn't indicate any harm, but in ideal world this should be 
> fixed.  I don't know perl, unfortunately.

--- msvcmaker.old	2006-08-04 17:07:28.000000000 +0200
+++ msvcmaker	2006-08-04 17:07:06.000000000 +0200
@@ -45,7 +45,7 @@

my $type = "win32";

-    open(IN, "< $wine_dir/$spec_file");
+    open(IN, "< $wine_dir/$spec_file") || die "Error : Can't open $wine_dir/$spec_file : $!\n";

my $header = 1;
     my $lookahead = 0;
@@ -115,7 +115,7 @@
 my %wine_test_dsp_files;

MAKEFILE_IN: foreach my $makefile_in_file (@makefile_in_files) {
-    open(IN, "< $wine_dir/$makefile_in_file");
+    open(IN, "< $wine_dir/$makefile_in_file") || die "Error : Can't open $wine_dir/$makefile_in_file : $!\n";

my $topobjdir;
     my $module;