Re: d3dx9_36 [patch 2 of 3]: Implementation of D3DXSHScale

[Matteo Bruni]

2012/6/27 Nozomi Kodama :
>

-@ stub D3DXSHScale(ptr long ptr ptr)
+@ stdcall D3DXSHScale(ptr long ptr ptr)
...
+FLOAT* WINAPI D3DXSHScale(FLOAT *out, UINT order, CONST FLOAT *a,
CONST FLOAT scale)

The last parameter doesn't match between the function prototype and
the spec entry. Also, apparently MSDN agrees with your prototype,
while the docs in the last DirectX SDK have a pointer there. I guess
the tests demonstrate that the parameter is actually a plain float...

+    for (i = 0; i < 100; i++)
+    {
+        a[i] = (FLOAT)i;
+        b[i] = (FLOAT)i;
+    }

No need to cast.

+        D3DXSHScale(b, order, a, 5.0f);

Not important, but you could also verify that the returned pointer is == b.

+/* D3DXSHScale does not modify the elements of the array after the
order * order-th element */

Can you please indent those comments?

+    return;
+}

That's not needed at all.

Also, while you're at it, you should probably merge the two for loops
in the test, like Francois did in
http://www.winehq.org/pipermail/wine-patches/2012-June/115464.html