dlls/commdlg/fontdlg.c regression

[Gerald Pfeifer]

The following change to dlls/commdlg/fontdlg.c

revision 1.70
   date: 2004/08/14 00:42:35;  author: julliard;  state: Exp;  lines: +2 -5
   Jacek Caban 
   Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand
   in FormatCharDlgProcW.

causes the following warning with GCC 3.3.2 on FreeBSD 4.10:

fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible pointer type

Would you mind fixing this?

Thanks,
Gerald

[Gerald Pfeifer]

I believe I saw a patch for this, but WineHQ CVS still has this problem.

On Sun, 15 Aug 2004, Gerald Pfeifer wrote:
> The following change to dlls/commdlg/fontdlg.c
>
> revision 1.70
>  date: 2004/08/14 00:42:35;  author: julliard;  state: Exp;  lines: +2 -5
>  Jacek Caban 
>  Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand
>  in FormatCharDlgProcW.
>
> causes the following warning with GCC 3.3.2 on FreeBSD 4.10:
>
> fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible 
> pointer type

Gerald

[Jacek Caban]

Gerald Pfeifer wrote:
> I believe I saw a patch for this, but WineHQ CVS still has this problem.
>
> On Sun, 15 Aug 2004, Gerald Pfeifer wrote:
> > The following change to dlls/commdlg/fontdlg.c
> >
> > revision 1.70
> >  date: 2004/08/14 00:42:35;  author: julliard;  state: Exp;  lines: 
> > +2 -5
> >  Jacek Caban 
> >  Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand
> >  in FormatCharDlgProcW.
> >
> > causes the following warning with GCC 3.3.2 on FreeBSD 4.10:
> >
> > fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from 
> > incompatible pointer type
>
> Gerald

I've sent patch to this:
http://www.winehq.org/hypermail/wine-patches/2004/08/0365.html
This patch is still not applied probably because of some bugs in 16-bit 
fuctions. Now I don't have tmie to check this,
but I will as soon as possible. If anyone wants - feel free to fix it 
and send the patch.

[Gerald Pfeifer]

On Tue, 7 Sep 2004, Jacek Caban wrote:
> > On Sun, 15 Aug 2004, Gerald Pfeifer wrote:
> > > The following change to dlls/commdlg/fontdlg.c
> > >
> > > revision 1.70
> > >  date: 2004/08/14 00:42:35;  author: julliard;  state: Exp;  lines: +2 -5
> > >  Jacek Caban 
> > >  Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand
> > >  in FormatCharDlgProcW.
> > >
> > > causes the following warning with GCC 3.3.2 on FreeBSD 4.10:
> > >
> > > fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from 
> > > incompatible pointer type
>
> I've sent patch to this:
> http://www.winehq.org/hypermail/wine-patches/2004/08/0365.html
> This patch is still not applied probably because of some bugs in 16-bit 
> fuctions. Now I don't have tmie to check this,
> but I will as soon as possible. If anyone wants - feel free to fix it and 
> send the patch.

Does anyone have an update on this?  I am still seeing this...

Gerald