Re: [PATCH 3/5] d3dx9: Turn a "Out of bounds" FIXME into a WARN.

[Paul Gofman]

Matteo,

I am curious why would you want to change this FIXME to WARN? We 
know that native implementation does not fail effect creation in this case.

Regards,
     Paul.

On 06/09/2017 10:19 PM, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni
>
> It could be triggered by broken preshaders.
>
> dlls/d3dx9_36/preshader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c
> index 522d4841f9..d0cff22e4a 100644
> --- a/dlls/d3dx9_36/preshader.c
> +++ b/dlls/d3dx9_36/preshader.c
> @@ -868,7 +868,7 @@ static HRESULT parse_preshader(struct d3dx_preshader *pres, unsigned int *ptr, u
>               }
>               if (reg_idx >= pres->regs.table_sizes[table])
>               {
> -
>            FIXME("Out of bounds register index, i %u, j %u, table %u, reg_idx %u.\n",
> -
>            WARN("Out of bounds register index, i %u, j %u, table %u, reg_idx %u.\n",
>                     i, j, table, reg_idx);
>             return D3DXERR_INVALIDDATA;
>         }

[PATCH 3/5] d3dx9: Turn a "Out of bounds" FIXME into a WARN.

[Matteo Bruni]

2017-06-11 17:13 GMT+02:00 Paul Gofman :
> Matteo,
> I am curious why would you want to change this FIXME to WARN? We know
>
> that native implementation does not fail effect creation in this case.
>
> Regards,
>     Paul.

Right, I forgot about it. Thanks.

I guess this begs for a comment in the code to avoid that I try to
make the change again. I'll probably send something. Or remind me if I
forget again :)

Alexandre, please ignore this patch for the time being.