Strange zero operation in dlls/riched20/tests/editor.c (Coverity)

[Marcus Meissner]

Hi Dylan, folks,

Coverity sees following constructs in dlls/riched20/tests/editor.c
introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da

+    SendMessage(hwndRichEdit, WM_CHAR, 22,
+                (MapVirtualKey('V', MAPVK_VK_TO_VSC) << 16) & 1);
(several more of similar)

The 4th argument is always 0 (because of (x<<16)&1).

You added that Dylan, was perhaps |1 intended for a repeat count of 1?

Ciao, Marcus

[Dylan Smith]

On Thu, May 5, 2011 at 11:39 AM, Marcus Meissner  wrote:
> Hi Dylan, folks,
>
> Coverity sees following constructs in dlls/riched20/tests/editor.c
> introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da
> - SendMessage(hwndRichEdit, WM_CHAR, 22,
> -
>            (MapVirtualKey('V', MAPVK_VK_TO_VSC) << 16) & 1);
>
> (several more of similar)
>
> The 4th argument is always 0 (because of (x<<16)&1).
>
> You added that Dylan, was perhaps |1 intended for a repeat count of 1?
>
> Yes, I believe you are right.  Thanks for catching that.