[PATCH 1/8] adsldp: Fix memory leak.

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov 
---
 dlls/adsldp/adsldp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/adsldp/adsldp.c b/dlls/adsldp/adsldp.c
index 4957828391..76a3f285c4 100644
--- a/dlls/adsldp/adsldp.c
+++ b/dlls/adsldp/adsldp.c
@@ -1169,7 +1169,10 @@ static HRESULT WINAPI search_ExecuteSearch(IDirectorySearch *iface, LPWSTR filte

props = heap_alloc((count + 1) * sizeof(props[0]));
         if (!props)
+        {
+            heap_free(ldap_ctx);
             return E_OUTOFMEMORY;
+        }

for (i = 0; i < count; i++)
             props[i] = names[i];

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=68170

Your paranoid android.

=== debiant (32 bit WoW report) ===

adsldp:
ldap.c:153: Test failed: 7: got 0x8007203a, expected 0
ldap.c:170: Test failed: 7: got 0x8007203a, expected 0
ldap.c:153: Test failed: 8: got 0x8007203a, expected 0

=== debiant (64 bit WoW report) ===

adsldp:
ldap.c:103: Test failed: 5: got 0x8007203a, expected 0
ldap.c:108: Test failed: 5: got 0x8007203a, expected 0
ldap.c:103: Test failed: 7: got 0x8007203a, expected 0
ldap.c:108: Test failed: 7: got 0x8007203a, expected 0
ldap.c:103: Test failed: 8: got 0x8007203a, expected 0
ldap.c:108: Test failed: 8: got 0x8007203a, expected 0
ldap.c:103: Test failed: 10: got 0x8007203a, expected 0
ldap.c:108: Test failed: 10: got 0x8007203a, expected 0
ldap.c:103: Test failed: 11: got 0x8007203a, expected 0x80005000
ldap.c:153: Test failed: 5: got 0x8007203a, expected 0
ldap.c:170: Test failed: 5: got 0x8007203a, expected 0
ldap.c:153: Test failed: 14: got 0x8007203a, expected 0

[Dmitry Timoshkov]

Marvin  wrote:
> === debiant (32 bit WoW report) ===
>
> adsldp:
> ldap.c:153: Test failed: 7: got 0x8007203a, expected 0
> ldap.c:170: Test failed: 7: got 0x8007203a, expected 0
> ldap.c:153: Test failed: 8: got 0x8007203a, expected 0

0x8007203a means ERROR_DS_SERVER_DOWN. While detection of such situations
in the tests could be improved, that doesn't seem like the real case here,
since other tests besides mentioned above didn't fail, and other VMs didn't
fail either.

In any case I'll try to add a patch that adds handling for this testbot
failures.