Re: [RESENT] Check for a valid buffer in NTReadFile

[Alexandre Julliard]

Uwe Bonnes  writes:
>    Changelog:
>    wine/dlls/ntdll/file.c: NtReadFile()
>    Reject a NULL buffer       

That should be handled by the EFAULT case already. Why does it make a
difference for you?

[RESENT] Check for a valid buffer in NTReadFile

[Uwe Bonnes]

> > > > > "Alexandre" == Alexandre Julliard  writes:

Alexandre> Uwe Bonnes  writes:
    >> Changelog: wine/dlls/ntdll/file.c: NtReadFile() Reject a NULL buffer

Alexandre> That should be handled by the EFAULT case already. Why does
    Alexandre> it make a difference for you?

The EFAULT handler doesn't trigger for the test in
wine/dll/kernel/test/file.c:1389

Without the extra check, the test fails.

[RESENT] Check for a valid buffer in NTReadFile

[Alexandre Julliard]

Uwe Bonnes  writes:
> The EFAULT handler doesn't trigger for the test in
> wine/dll/kernel/test/file.c:1389
>
> Without the extra check, the test fails.

The test works fine here. Looks like you'll need to debug this
further.

[RESENT] Check for a valid buffer in NTReadFile

[Uwe Bonnes]

> > > > > "Alexandre" == Alexandre Julliard  writes:

Alexandre> Uwe Bonnes  writes:
    >> The EFAULT handler doesn't trigger for the test in
    >> wine/dll/kernel/test/file.c:1389
    >> 
    >> Without the extra check, the test fails.

Alexandre> The test works fine here. Looks like you'll need to debug
    Alexandre> this further.

The test fails for me on three machines (all Suse 9.3 with a recent kernel);

A +relay,+file,+ntdll,+server log looks like
0009:Call kernel32.ReadFile(00000024,00000000,0000000a,7ba1fc4c,00000000) ret=7ba4ec0d
trace:file:ReadFile 0x24 (nil) 10 0x7ba1fc4c (nil)
0009:Call ntdll.NtReadFile(00000024,00000000,00000000,00000000,7ba1fb64,00000000,0000000a,00000000,00000000) ret=7bb5b04c
trace:ntdll:NtReadFile (0x24,(nil),(nil),(nil),0x7ba1fb64,(nil),0x0000000a,(nil),(nil)),partial stub!
0009: get_handle_fd( handle=0x24, access=80000000 )
0009: get_handle_fd() = 0 { fd=10, flags=0 }
trace:ntdll:NtReadFile = 0x00000000
0009:Ret  ntdll.NtReadFile() retval=00000000 ret=7bb5b04c
0009:Ret  kernel32.ReadFile() retval=00000001 ret=7ba4ec0d

--
Uwe Bonnes                [e-mail]

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------