[PATCH] mshtml: Add better stub for HTMLDocument7::get_onmsthumbnailclick.

[Dmitry Timoshkov]

Signed-off-by: Dmitry Timoshkov 
---
 dlls/mshtml/htmldoc.c   | 3 ++-
 dlls/mshtml/tests/dom.c | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c
index 868a9a0048..ee1492d83b 100644
--- a/dlls/mshtml/htmldoc.c
+++ b/dlls/mshtml/htmldoc.c
@@ -3340,7 +3340,8 @@ static HRESULT WINAPI HTMLDocument7_get_onmsthumbnailclick(IHTMLDocument7 *iface
 {
     HTMLDocument *This = impl_from_IHTMLDocument7(iface);
     FIXME("(%p)->(%p)\n", This, p);
-    return E_NOTIMPL;
+    V_VT(p) = VT_NULL;
+    return S_OK;
 }

static HRESULT WINAPI HTMLDocument7_get_characterSet(IHTMLDocument7 *iface, BSTR *p)
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index 01c6191a6e..e152c4fc25 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -7014,6 +7014,7 @@ static void test_dom_implementation(IHTMLDocument2 *doc)
         IHTMLDocument7 *new_document;
         IHTMLLocation *location;
         IHTMLWindow2 *window;
+        VARIANT v;
         IDispatch *disp;

test_disp((IUnknown*)dom_implementation, &DIID_DispHTMLDOMImplementation, NULL, "[object]");
@@ -7045,6 +7046,12 @@ static void test_dom_implementation(IHTMLDocument2 *doc)
         hres = IHTMLDocument2_get_location(new_document2, &location);
         ok(hres == E_UNEXPECTED, "get_location returned: %08x\n", hres);

+        memset(&v, 0xcc, sizeof(v));
+        hres = IHTMLDocument7_get_onmsthumbnailclick(new_document, &v);
+        ok(hres == S_OK, "get_onmsthumbnailclick returned: %08x\n", hres);
+        ok(V_VT(&v) == VT_NULL, "got %u\n", V_VT(&v));
+        ok((DWORD)(DWORD_PTR)V_DISPATCH(&v) == 0xcccccccc, "got %p\n", V_DISPATCH(&v));
+
         IHTMLDocument2_Release(new_document2);
         IHTMLDocument7_Release(new_document);
         IHTMLDOMImplementation2_Release(dom_implementation2);

[Jacek Caban]

Hi Dmitry,

On 6/14/19 12:46 PM, Dmitry Timoshkov wrote:
> Signed-off-by: Dmitry Timoshkov
>
> dlls/mshtml/htmldoc.c   | 3 ++-
>   dlls/mshtml/tests/dom.c | 7 +++++++
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c
> index 868a9a0048..ee1492d83b 100644
> --- a/dlls/mshtml/htmldoc.c
> +++ b/dlls/mshtml/htmldoc.c
> @@ -3340,7 +3340,8 @@ static HRESULT WINAPI HTMLDocument7_get_onmsthumbnailclick(IHTMLDocument7 *iface
>   {
>       HTMLDocument *This = impl_from_IHTMLDocument7(iface);
>       FIXME("(%p)->(%p)\n", This, p);
> - return E_NOTIMPL;
> - V_VT(p) = VT_NULL;
> - return S_OK;

We have a mechanism in place for such stubs, see EVENT_FIXME in events 
like beforeactivate.

Thanks,

Jacek