re: winemenubuilder: Add support for 24 and 32 bit icons using png format.

[Dan Kegel]

Your patch applies and creates .png icons...
But it seems to create the icons with two suffixes, e.g. file shows
  a680_forum.png.xpm: PNG image data, 32 x 32, 8-bit/color RGB, non-interlaced
Shouldn't that just be .png, not .png.xpm?

(This is for http://bugs.winehq.org/show_bug.cgi?id=4803 )

winemenubuilder: Add support for 24 and 32 bit icons using png format.

[Vitaliy Margolen]

Dan Kegel wrote:
> Your patch applies and creates .png icons...
> But it seems to create the icons with two suffixes, e.g. file shows
>   a680_forum.png.xpm: PNG image data, 32 x 32, 8-bit/color RGB, non-interlaced
> Shouldn't that just be .png, not .png.xpm?
>
> (This is for http://bugs.winehq.org/show_bug.cgi?id=4803 )

Where are seeing that file? Also are you sure you are using patches 
wineshelllink? That's what copies the icon from c:\windows\temp to 
~/.local/share/icons

Vitaliy.

winemenubuilder: Add support for 24 and 32 bit icons using png format.

[Dan Kegel]

On Sun, Mar 23, 2008 at 5:45 PM, Vitaliy Margolen
 wrote:
> Where are seeing that file? Also are you sure you are using patches
>  wineshelllink?

My bad.  To use a noninstalled wineshelllink, you have
to start the installer with
   PATH=$HOME/wine-git/tools:$PATH wine-git/wine installers/BLMInstall277.exe
and then the icons are fine, since it's using the new code in the build tree.

Oddly, the link and shortcut on the desktop don't use any
of the icons, but the ones in the Wine menu look good.

winemenubuilder: Add support for 24 and 32 bit icons using png format.

[Vitaliy Margolen]

Dan Kegel wrote:
> On Sun, Mar 23, 2008 at 5:45 PM, Vitaliy Margolen
>  wrote:
> > Where are seeing that file? Also are you sure you are using patches
> >  wineshelllink?
>
> My bad.  To use a noninstalled wineshelllink, you have
> to start the installer with
>    PATH=$HOME/wine-git/tools:$PATH wine-git/wine installers/BLMInstall277.exe
> and then the icons are fine, since it's using the new code in the build tree.

I just did 'ln -s wine.git/tools/wineshelllink ~/bin/wineshelllink'
> Oddly, the link and shortcut on the desktop don't use any
> of the icons, but the ones in the Wine menu look good.

Strange, unless there are some other problems with extracting an icon. Can 
you run this and attach the output?

WINEDEBUG=+menubuilder wine winemenubuilder 
"c:\windows\profiles\$USER\desktop\file.lnk"

Vitaliy.