2009/11/9 Stefan Leichter Stefan.Leichter@camline.com:
my crystal ball is still not working, therefore resending unchanged
Try http://source.winehq.org/patches/
And indeed, the patch doesn't apply:
diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c --- a/wine-git/dlls/setupapi/install.c +++ b/wine-build/dlls/setupapi/install.c
Note that you're also adding whitespace errors.
Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
2009/11/9 Stefan Leichter Stefan.Leichter@camline.com:
my crystal ball is still not working, therefore resending unchanged
Try http://source.winehq.org/patches/
And indeed, the patch doesn't apply:
diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c --- a/wine-git/dlls/setupapi/install.c +++ b/wine-build/dlls/setupapi/install.c
i don't know where this stupid a/ and b/ was added. They are not in the original patch see http://www.winehq.org/pipermail/wine-patches/attachments/20091109/8912a56f/a...
Note that you're also adding whitespace errors.
I will check for whitespace problems
Stefan Leichter Stefan.Leichter@camline.com writes:
Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
2009/11/9 Stefan Leichter Stefan.Leichter@camline.com:
my crystal ball is still not working, therefore resending unchanged
Try http://source.winehq.org/patches/
And indeed, the patch doesn't apply:
diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c --- a/wine-git/dlls/setupapi/install.c +++ b/wine-build/dlls/setupapi/install.c
i don't know where this stupid a/ and b/ was added. They are not in the original patch see http://www.winehq.org/pipermail/wine-patches/attachments/20091109/8912a56f/a...
They are added by the new patch filter, which tries to make everything appliable with git apply, and currently requires non-git patches to be based at the top of the tree. I'll look into supporting your case, but using git to format patches is strongly recommended.
Am Tuesday 10 November 2009 10:09:22 schrieb Henri Verbeet:
2009/11/9 Stefan Leichter Stefan.Leichter@camline.com:
my crystal ball is still not working, therefore resending unchanged
Try http://source.winehq.org/patches/
And indeed, the patch doesn't apply:
diff -urw wine-git/dlls/setupapi/install.c wine-build/dlls/setupapi/install.c --- a/wine-git/dlls/setupapi/install.c +++ b/wine-build/dlls/setupapi/install.c
Note that you're also adding whitespace errors.
When reviewing the patch i found two line containing only spaces. But this are to my understanding no "whitespace errors". Can you please tell me what else you have seen ?
Thanks Stefan
2009/11/10 Stefan Leichter Stefan.Leichter@camline.com:
When reviewing the patch i found two line containing only spaces. But this are to my understanding no "whitespace errors". Can you please tell me what else you have seen ?
That counts as trailing spaces. Note that git apply warns about white space errors by default.
-
Alexandre Julliard -
Henri Verbeet -
Stefan Leichter