comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM

[ricardo filipe]

this is related to http://bugs.winehq.org/show_bug.cgi?id=8072

so... i decided to investigate why didn't media player classic show the files when browsing...
i've been debugging this for some days but found the problem, although it's not
quite solved, so if anyone has any idea please share.

the good thing was that mpc source code is available so i could see how it was
implemented.
i found out that includeObject is supposed to notify the browsing window with
CDN_INCLUDEITEM that wasn't yet declared in wine.
the problem is that i get:

err:pidl:_ILSimpleGetTextW -- no text
err:pidl:_ILSimpleGetTextW -- no text
trace:commdlg:SendCustomDlgNotificationMessage RET NOTIFY
trace:commdlg:SendCustomDlgNotificationMessage Retval: 0x00000000

and the notify isn't successful :\
any ideas?

patch in attachment...

_________________________________________________________________
Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger!
http://www.amigosdomessenger.com.br/

comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM

[ricardo filipe]

so i just saw this insightful comment in filedlg.c:

* FIXME: CDN_FILEOK is wrong implemented, other CDN_ messages likely too

must be why it doesn't really notify the window :\
send_message() needs to be fixed for this.
> From: [e-mail]
> To: [e-mail]
> Subject: comdlg32: includeobject needs to notify window with CDN_INCLUDEITEM
> Date: Sun, 7 Dec 2008 20:48:50 +0000
>
> this is related to http://bugs.winehq.org/show_bug.cgi?id=8072
>
> so... i decided to investigate why didn't media player classic show the files when browsing...
> i've been debugging this for some days but found the problem, although it's not
> quite solved, so if anyone has any idea please share.
>
> the good thing was that mpc source code is available so i could see how it was
> implemented.
> i found out that includeObject is supposed to notify the browsing window with
> CDN_INCLUDEITEM that wasn't yet declared in wine.
> the problem is that i get:
>
> err:pidl:_ILSimpleGetTextW -- no text
> err:pidl:_ILSimpleGetTextW -- no text
> trace:commdlg:SendCustomDlgNotificationMessage RET NOTIFY
> trace:commdlg:SendCustomDlgNotificationMessage Retval: 0x00000000
>
> and the notify isn't successful :\
> any ideas?
>
> patch in attachment...
>
> Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger!
> http://www.amigosdomessenger.com.br/

_________________________________________________________________
Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video!
http://video.msn.com/?mkt=pt-br