Re: Truncate MIDI SysEx messages after termination byte

[Christian Costa]

Le 09/01/2013 03:12, Johannes Kroll a écrit :
> While using the KORG Kontrol Editor software [1] under Wine to configure
> my nanoPAD2 MIDI controller, I noticed that uploading parameters to the
> hardware doesn't work. The program displays a timeout message.
>
> The program relies on the MIDI driver to remove data after the SysEx
> termination byte [2], but the Wine's winmm implementation doesn't do
> this. The complete MIDIHDR buffer is sent, including excess bytes in the
> case when the buffer is larger than the MIDI message.
>
> The attached patch fixes the problem by truncating SysEx messages after
> the termination byte, ignoring any excess bytes.
>
> I tested the patch with KORG Kontrol Editor under Ubuntu 12.04 64-bit
> (32-bit wine).
>
> [1] http://www.korg.co.uk/support/downloads/nano2_dl.php
> [2] http://home.roadrunner.com/~jgglatt/tech/midispec/sysex.htm

Hi,

Please be consistent when using space. 1 space before and after 
operators (<, ==, =, ...).

Christian

Truncate MIDI SysEx messages after termination byte

[Johannes Kroll]

Hi,

On Wed, 09 Jan 2013 03:55:25 +0100
Christian Costa  wrote:
> Hi,
>
> Please be consistent when using space. 1 space before and after 
> operators (<, ==, =, ...).

spaces inserted. HTH.

J.

Truncate MIDI SysEx messages after termination byte

[Christian Costa]

Le 09/01/2013 04:26, Johannes Kroll a écrit :
> Hi,
>
> On Wed, 09 Jan 2013 03:55:25 +0100
> Christian Costa  wrote:
> > Hi,
> >
> > Please be consistent when using space. 1 space before and after
> > operators (<, ==, =, ...).
>
> spaces inserted. HTH.
>
> J.

That's better. You forgot some occurences in the for loop though.

Christian

Truncate MIDI SysEx messages after termination byte

[Johannes Kroll]

On Wed, 09 Jan 2013 10:19:54 +0100
Christian Costa  wrote:
> Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > Hi,
> >
> > On Wed, 09 Jan 2013 03:55:25 +0100
> > Christian Costa  wrote:
> > > Hi,
> > >
> > > Please be consistent when using space. 1 space before and after
> > > operators (<, ==, =, ...).
> >
> > spaces inserted. HTH.
> >
> > J.
>
> That's better. You forgot some occurences in the for loop though.

Is it OK if I leave the rest of the formatting to you? Any style is
fine with me, whatever makes you happy and hopefully gets the patch
included.