Re: [PATCH 1/2] winmm: Only start the devices thread when necessary

[Alexandre Julliard]

Andrew Eikum  writes:
> Fixes bug 28042.
>
> dlls/winmm/waveform.c |  106 ++++++++++++++++++++++++++++++++++++-------------
>  1 files changed, 78 insertions(+), 28 deletions(-)

It doesn't work here:

../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok
wine: Unhandled page fault on read access to 0x69187f74 at address 0x558812f9 (thread 0009), starting debugger...
Unhandled exception: page fault on read access to 0x69187f74 in 32-bit code (0x558812f9).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:558812f9 ESP:0032e840 EBP:0032f778 EFLAGS:00010206(  R- --  I   - -P- )
 EAX:0012ff90 EBX:5588f200 ECX:69187f60 EDX:0012fe30
 ESI:00000000 EDI:0032ecdc
Stack dump:
0x0032e840:  0012ff90 5588816c 0032f504 0032f754
0x0032e850:  55887f4c 0032f504 0032f6e0 00000000
0x0032e860:  00000000 00000000 00000000 00000000
0x0032e870:  0012fda8 0012fe30 0032e908 68352582
0x0032e880:  000000a0 00000000 6834ed1d 683b710c
0x0032e890:  0032eb18 00000000 0032e978 0032f834
Backtrace:
=>0 0x558812f9 DEVENUM_ICreateDevEnum_CreateClassEnumerator+0x10c9(iface=0x55891e4c, clsidDeviceClass=0x32f834, ppEnumMoniker=0x32f870, dwFlags=0) [/home/julliard/wine/wine/dlls/devenum/createdevenum.c:727] in devenum (0x0032f778)
  1 0x69104bb2 (0x0032f898)
  2 0x69101229 (0x0032faa8)
  3 0x6876955a test_render_filter_priority+0x1589() [/home/julliard/wine/wine/dlls/quartz/tests/filtergraph.c:1846] in quartz_test (0x0032fcd8)
  4 0x68769fa3 func_filtergraph+0x562() [/home/julliard/wine/wine/dlls/quartz/tests/filtergraph.c:1895] in quartz_test (0x0032fd58)
  5 0x68763392 main+0x3a1(argc=*** Invalid address 0x69187f60 ***
, argv=*** Invalid address 0x69187f64 ***
Internal symbol error: unable to access memory location 0x69187f64) [/home/julliard/wine/wine/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fe28)
  6 0x6876f865 __wine_spec_exe_entry+0x74(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe70)
  7 0x684895bc call_process_entry+0xb() in kernel32 (0x0032fe88)
  8 0x6848a73f start_process+0x5e(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:1084] in kernel32 (0x0032fec8)
  9 0x68376de0 call_thread_func_wrapper+0xb() in ntdll (0x0032fed8)
  10 0x68379acd call_thread_func+0x7c(entry=0x6848a6e0, arg=0x7ffdf000, frame=0x32ffc8) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2532] in ntdll (0x0032ffa8)
  11 0x68376dbe call_thread_entry_point+0x11() in ntdll (0x0032ffc8)
  12 0x6834eece start_process+0x1d(kernel_start=0x6848a6e0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8)
  13 0x68028a9d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000)
0x558812f9 DEVENUM_ICreateDevEnum_CreateClassEnumerator+0x10c9 [/home/julliard/wine/wine/dlls/devenum/createdevenum.c:727] in devenum: call	*0x14(%ecx)
727		        res = IFilterMapper2_RegisterFilter(pMapper,