Re: [PATCH 2/4] shell32: Register standard known folders on initialization.

[Alexandre Julliard]

Mariusz Pluciński  writes:
> -
>    for(i=0; i < sizeof(CSIDL_Data)/sizeof(CSIDL_Data[0]); ++i)
> -
>    {
> -
>        if(!CSIDL_Data[i].szValueName)
> -
>        {
> -
>            FIXME("known folder %d has no value name, ignoring\n", i);
> -
>            continue;
> -
>        }
> -
> -
>        /* FIXME: remove this check after fixing all known folders definitions */
> -
>        if(is_knownfolder_registered(CSIDL_Data[i].id))
> -
>        {
> -
>            FIXME("known folder %d already registered, ignoring\n", i);
> -
>            continue;
> -
>        }

It's pretty annoying to see these fixmes on every prefix update. You
don't need them anyway, what needs to be done is clear from the code.