Re: vcomp: Add _vcomp_enter_critsect, _vcomp_leave_critsect, omp_init_lock stubs

[Michael Stefaniuc]

Hello Andrey,

On 03/14/2015 03:00 PM, Andrey Gusev wrote:
> Based on an old patch from Dan Kegel with the addition.
> Fixes https://bugs.winehq.org/show_bug.cgi?id=36457
>
> vcomp-Add-_vcomp_enter_critsect-_vcomp_leave_critsec.txt

you can't just stub out locking functions. It is far superior to have a
program crash straight ahead than to silently corrupt data.
That's the reason the initial submission by Dan was rejected.

I don't find any documentation on a quick search for this functions. But
they look to me just like wrappers around the standard
EnterCriticalSection / LeaveCriticalSection functions. You could try
that out and see if your application is happy with that.

bye
    michael
> From b4c7617b344ee0dcdb058030b19ede5101787824 Mon Sep 17 00:00:00 2001
> Message-Id: 
> From: Andrey Gusev 
> Date: Sat, 14 Mar 2015 15:53:29 +0200
> Subject: [PATCH] vcomp: Add _vcomp_enter_critsect, _vcomp_leave_critsect,
>  omp_init_lock stubs
>
> dlls/vcomp/main.c     | 15 +++++++++++++++
>  dlls/vcomp/vcomp.spec |  6 +++---
>  2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/vcomp/main.c b/dlls/vcomp/main.c
> index ab2a372..3c43a4e 100644
> --- a/dlls/vcomp/main.c
> +++ b/dlls/vcomp/main.c
> @@ -71,6 +71,11 @@ double CDECL omp_get_wtime(void)
>      return GetTickCount() / 1000.0;
>  }
>
> +void CDECL omp_init_lock(int lock)
> +{
> - TRACE("(%d): stub\n", lock);
>
> +}
> -
>
> void CDECL omp_set_dynamic(int val)
>  {
>      TRACE("(%d): stub\n", val);