Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?

[GOUJON Alexandre]

Hi,

My patch (http://source.winehq.org/patches/data/88072) is marked as 
"Build failure".
I tried with the latest (today) HEAD and I successfully applied it.
Compilation also works for me at least on my x86 and x86_64 computers.
Moreover, the Wine Test Bot tested it without any issue, see 
https://testbot.winehq.org/JobDetails.pl?Key=19936.

I know your machine is a bit "mystic".
Can you show me your output to help me diagnosing your build failure ?

Thanks

[Alexandre Julliard]

GOUJON Alexandre  writes:
> Hi,
>
> My patch (http://source.winehq.org/patches/data/88072) is marked as
> "Build failure".
> I tried with the latest (today) HEAD and I successfully applied it.
> Compilation also works for me at least on my x86 and x86_64 computers.
> Moreover, the Wine Test Bot tested it without any issue, see
> https://testbot.winehq.org/JobDetails.pl?Key=19936.
>
> I know your machine is a bit "mystic".
> Can you show me your output to help me diagnosing your build failure ?

There's nothing mystic about it, but when you are changing the Mac code,
testing the build on a Mac is recommended ;-)

gcc -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/sw/include/freetype2 -I/sw/include -I/sw/include -g -O2  -o cdrom.o cdrom.c
cdrom.c: In function 'DVD_ReadStructure':
cdrom.c:2718: error: invalid type argument of '->'
cdrom.c:2719: error: invalid type argument of '->'
cdrom.c:2720: error: invalid type argument of '->'
cdrom.c:2721: error: invalid type argument of '->'
cdrom.c:2721: error: invalid type argument of '->'
cdrom.c:2721: error: invalid type argument of '->'
cdrom.c:2721: error: invalid type argument of '->'
make[1]: *** [cdrom.o] Error 1

[GOUJON Alexandre]

On 07/16/2012 06:12 PM, Alexandre Julliard wrote:
> There's nothing mystic about it, but when you are changing the Mac code,
> testing the build on a Mac is recommended ;-)
>
> gcc -m32 -c -I. -I. -I../../include -I../../include  -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -I/sw/include/freetype2 -I/sw/include -I/sw/include -g -O2  -o cdrom.o cdrom.c
> cdrom.c: In function 'DVD_ReadStructure':
> cdrom.c:2718: error: invalid type argument of '->'
> cdrom.c:2719: error: invalid type argument of '->'
> cdrom.c:2720: error: invalid type argument of '->'
> cdrom.c:2721: error: invalid type argument of '->'
> cdrom.c:2721: error: invalid type argument of '->'
> cdrom.c:2721: error: invalid type argument of '->'
> cdrom.c:2721: error: invalid type argument of '->'
> make[1]: *** [cdrom.o] Error 1

Sorry about that : I don't have access to a Mac, even virtualized.
A good developer can write code without compiling it but obviously, I'm 
not good enough.
Anyway, I just sent a fifth try.