[PATCH] ntdll: Save status from attaching dependencies in process_attach().

[Jan Sikorski]

Signed-off-by: Jan Sikorski 
---
I don't know for sure if that's an actual bug, but it looks like it was
changed accidentally in 0dd37b02f99f5090dd855343fcd8a99496047f3e.
---
 dlls/ntdll/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c
index a754579bf54..5bae44f175d 100644
--- a/dlls/ntdll/loader.c
+++ b/dlls/ntdll/loader.c
@@ -1552,7 +1552,7 @@ static NTSTATUS process_attach( LDR_DDAG_NODE *node, LPVOID lpReserved )
     if (wm->ldr.ActivationContext) RtlActivateActivationContext( 0, wm->ldr.ActivationContext, &cookie );

/* Recursively attach all DLLs this one depends on */
-    walk_node_dependencies( node, lpReserved, process_attach );
+    status = walk_node_dependencies( node, lpReserved, process_attach );

if (!wm->ldr.InInitializationOrderLinks.Flink)
         InsertTailList(&NtCurrentTeb()->Peb->LdrData->InInitializationOrderModuleList,

[Paul Gofman]

On 11/22/21 16:59, Jan Sikorski wrote:
> Signed-off-by: Jan Sikorski
>
> I don't know for sure if that's an actual bug, but it looks like it was
> changed accidentally in 0dd37b02f99f5090dd855343fcd8a99496047f3e.
>
> dlls/ntdll/loader.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c
> index a754579bf54..5bae44f175d 100644
> --- a/dlls/ntdll/loader.c
> +++ b/dlls/ntdll/loader.c
> @@ -1552,7 +1552,7 @@ static NTSTATUS process_attach( LDR_DDAG_NODE *node, LPVOID lpReserved )
>       if (wm->ldr.ActivationContext) RtlActivateActivationContext( 0, wm->ldr.ActivationContext, &cookie );
>   /* Recursively attach all DLLs this one depends on */
> - walk_node_dependencies( node, lpReserved, process_attach );
> -
>
> status = walk_node_dependencies( node, lpReserved, process_attach );
>
> if (!wm->ldr.InInitializationOrderLinks.Flink)
>      InsertTailList(&NtCurrentTeb()->Peb->LdrData->InInitializationOrderModuleList,

Thanks for spotting this, looks like an actual bug to me.