Re: Comctrl generic notification support

[Andreas Mohr]

Hi,

On Thu, Sep 05, 2002 at 01:54:50PM -0400, Dimitrie O. Paun wrote:
> ChangeLog
>   Add generic notification support to comctl32
> Index: dlls/comctl32/comctl32.h
>
> RCS file: /var/cvs/wine/dlls/comctl32/comctl32.h,v
> retrieving revision 1.16
> diff -u -r1.16 comctl32.h
> --- dlls/comctl32/comctl32.h	31 May 2002 23:25:43 -0000	1.16
> +++ dlls/comctl32/comctl32.h	5 Sep 2002 17:33:49 -0000
> @@ -4,6 +4,7 @@
> -
> - Copyright 1999 Thuy Nguyen
> - Copyright 1999 Eric Kohl
> -
> - Copyright 2002 Dimitrie O. Paun
> -
> - This library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public
>
> @@ -23,6 +24,8 @@
>  #ifndef __WINE_COMCTL32_H
>  #define __WINE_COMCTL32_H
>
> +#include "commctrl.h"
> -
>
> extern HMODULE COMCTL32_hModule;
>  extern HBRUSH  COMCTL32_hPattern55AABrush;
>
> @@ -125,4 +128,132 @@
>  #define WINE_FILEVERSION 5, COMCTL32_VERSION_MINOR, 0, 0
>  #define WINE_FILEVERSIONSTR "5.00"
>
> +/* Notification support */
> -
>
> +inline static LRESULT __send_notify(HWND hwnd, UINT code, NMHDR *hdr)

Isn't using double underscore for such non-system functions rather pretty
weird ?
(or IOW: even strongly discouraged ?)

Comctrl generic notification support

[Dimitrie O. Paun]

On September 5, 2002 02:42 pm, Andreas Mohr wrote:
> > +inline static LRESULT __send_notify(HWND hwnd, UINT code, NMHDR *hdr)
>
> Isn't using double underscore for such non-system functions rather pretty weird ?

I don't really care... I also don't think it's a problem, but if you feel strong about it,
I'll rename it. Alexandre?

Comctrl generic notification support

[Alexandre Julliard]

"Dimitrie O. Paun"  writes:
> I don't really care... I also don't think it's a problem, but if you feel strong about it,
> I'll rename it. Alexandre?

Can't say that I care much either. Personally I wouldn't use
underscores here, but if you like it that way it's fine. But of course
it will get you in trouble with the cosmetics police (hi Andreas ;-)

Comctrl generic notification support

[Dimitrie O. Paun]

On September 5, 2002 07:21 pm, Alexandre Julliard wrote:
> Can't say that I care much either. Personally I wouldn't use
> underscores here, but if you like it that way it's fine. But of course
> it will get you in trouble with the cosmetics police (hi Andreas ;-)

Fine, fine ... resent without the underscores.

--
Dimi.