Re: [v3 resend2] d3d9: call wined3d_device_copy_sub_resource_region instead of wined3d_device_update_surface in d3d9_device_UpdateSurface

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I spotted a few style issues. Not sure if that's what Henri didn't
like about it, or if he disagrees with the concept of the patch.

Am 2015-11-03 um 08:34 schrieb Riccardo Bortolato:
> - if (!(sub_resource = wined3d_texture_get_sub_resource(src->wined3d_texture, src->sub_resource_idx)))
> - {
> -
>    WARN("no subresource found for texture %p sub_resource_idx %u\n", src->wined3d_texture, src->sub_resource_idx);

We usually have a period at the end of wined3d trace messages.
> -
>    WARN("source %p must be SYSTEMMEM and dest %p must be DEFAULT, returning WINED3DERR_INVALIDCALL\n",
> -
>            src_surface, dst_surface);
> -
>    wined3d_mutex_unlock();
> -
>    return D3DERR_INVALIDCALL;

The trace message mentions the wrong return value (WINED3DERR... vs
D3DERR...).
> - hr = wined3d_device_copy_sub_resource_region(device->wined3d_device,
> -
>    wined3d_texture_get_resource(dst->wined3d_texture), dst->sub_resource_idx, dst_point ? dst_point->x : 0,
> -
>    dst_point ? dst_point->y : 0, 0, wined3d_texture_get_resource(src->wined3d_texture),
> -
>    src->sub_resource_idx, &src_box);

Indentation (8 spaces for the line continuations).

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWOKUmAAoJEN0/YqbEcdMwCaIP/A/V33gPqKBJtBJAXi8UnsEG
dENusnecbrxauf6Sc6x5g7cYriBUEph5ndYa96y+lv8qKuOg9jVLeoUkfBHqpE8f
V77p3cCnAJJ2XzbFJkqu8jY5GKvaAmoizezOyPRi/lgXa2xydH5yzW5NFu27Rbq8
KeG3kuBIBDzkJ1poSUvYWvSqUTGOeaUEYZBkDttqPegHvjPpYJg6MAzpr33c/F5P
s5ttSwhRdPFQJU3iktZKElhuUX2SBZnBwcueR4xAN+/4bRCIAhy2tnPXbQgC8Tih
dcQzVWCoQ+qK3nmYjDUrwvvWdEF78D+BOQzVtOOn4kHZwE1XQ7M1paV8en0uV0VS
D8Jdx4shCQGkxZncBsfysbEPkqgApukCFJp34JfXWFxlpVbiK6m2Y3DzsdyhGxek
Ky30AIY7FadUit5KWehcqDUj9Z8HOFdgcCe0KWqeFpeQn4G6t9gfJiiKYRV3m6TD
OxwLT+HcD4lozPARMTq6IT7pV3hOG0xdKNuTKfgji9+8RWRNz5nGa/Ml4WzS49lV
YHV06Nnb3ayw1CYTBoK2jwp5hBzAybdghSW7sKNJ6gLy3JFsZOKpKnr2yVxV1WD2
g8E5+tqwPDxgiriDOZrM5tPTc8+QLSaIm+Q59TKE3ScSvWVZArERVMtAk8/vd7BA
nAXvxDoQsVBSa7z+zwRC
=+ADb
-----END PGP SIGNATURE-----

[v3 resend2] d3d9: call wined3d_device_copy_sub_resource_region instead of wined3d_device_update_surface in d3d9_device_UpdateSurface

[Riccardo Bortolato]

Thanks, I sent an updated couple of patches.

Unfortunately I forgot the v4 tag, sorry for that.

Ciao,
Riccardo

2015-11-03 13:14 GMT+01:00 Stefan Dösinger :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi,
>
> I spotted a few style issues. Not sure if that's what Henri didn't
> like about it, or if he disagrees with the concept of the patch.
>
> Am 2015-11-03 um 08:34 schrieb Riccardo Bortolato:
> > - if (!(sub_resource = wined3d_texture_get_sub_resource(src->wined3d_texture, src->sub_resource_idx)))
> > - {
> > -
> >    WARN("no subresource found for texture %p sub_resource_idx %u\n", src->wined3d_texture, src->sub_resource_idx);
>
> We usually have a period at the end of wined3d trace messages.
> > -
> >    WARN("source %p must be SYSTEMMEM and dest %p must be DEFAULT, returning WINED3DERR_INVALIDCALL\n",
> > -
> >            src_surface, dst_surface);
> > -
> >    wined3d_mutex_unlock();
> > -
> >    return D3DERR_INVALIDCALL;
>
> The trace message mentions the wrong return value (WINED3DERR... vs
> D3DERR...).
> > - hr = wined3d_device_copy_sub_resource_region(device->wined3d_device,
> > -
> >    wined3d_texture_get_resource(dst->wined3d_texture), dst->sub_resource_idx, dst_point ? dst_point->x : 0,
> > -
> >    dst_point ? dst_point->y : 0, 0, wined3d_texture_get_resource(src->wined3d_texture),
> > -
> >    src->sub_resource_idx, &src_box);
>
> Indentation (8 spaces for the line continuations).
>
> Stefan
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWOKUmAAoJEN0/YqbEcdMwCaIP/A/V33gPqKBJtBJAXi8UnsEG
> dENusnecbrxauf6Sc6x5g7cYriBUEph5ndYa96y+lv8qKuOg9jVLeoUkfBHqpE8f
> V77p3cCnAJJ2XzbFJkqu8jY5GKvaAmoizezOyPRi/lgXa2xydH5yzW5NFu27Rbq8
> KeG3kuBIBDzkJ1poSUvYWvSqUTGOeaUEYZBkDttqPegHvjPpYJg6MAzpr33c/F5P
> s5ttSwhRdPFQJU3iktZKElhuUX2SBZnBwcueR4xAN+/4bRCIAhy2tnPXbQgC8Tih
> dcQzVWCoQ+qK3nmYjDUrwvvWdEF78D+BOQzVtOOn4kHZwE1XQ7M1paV8en0uV0VS
> D8Jdx4shCQGkxZncBsfysbEPkqgApukCFJp34JfXWFxlpVbiK6m2Y3DzsdyhGxek
> Ky30AIY7FadUit5KWehcqDUj9Z8HOFdgcCe0KWqeFpeQn4G6t9gfJiiKYRV3m6TD
> OxwLT+HcD4lozPARMTq6IT7pV3hOG0xdKNuTKfgji9+8RWRNz5nGa/Ml4WzS49lV
> YHV06Nnb3ayw1CYTBoK2jwp5hBzAybdghSW7sKNJ6gLy3JFsZOKpKnr2yVxV1WD2
> g8E5+tqwPDxgiriDOZrM5tPTc8+QLSaIm+Q59TKE3ScSvWVZArERVMtAk8/vd7BA
> nAXvxDoQsVBSa7z+zwRC
> =+ADb
> -----END PGP SIGNATURE-----

[v3 resend2] d3d9: call wined3d_device_copy_sub_resource_region instead of wined3d_device_update_surface in d3d9_device_UpdateSurface

[Riccardo Bortolato]

I made a mess with SHA-s, the updated couple is v5.

Sorry for the noise.

Ciao,
Riccardo

2015-11-03 13:51 GMT+01:00 Riccardo Bortolato :
> Thanks, I sent an updated couple of patches.
>
> Unfortunately I forgot the v4 tag, sorry for that.
>
> Ciao,
> Riccardo
>
> 2015-11-03 13:14 GMT+01:00 Stefan Dösinger :
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > Hi,
> >
> > I spotted a few style issues. Not sure if that's what Henri didn't
> > like about it, or if he disagrees with the concept of the patch.
> >
> > Am 2015-11-03 um 08:34 schrieb Riccardo Bortolato:
> > > - if (!(sub_resource = wined3d_texture_get_sub_resource(src->wined3d_texture, src->sub_resource_idx)))
> > > - {
> > > -
> > >    WARN("no subresource found for texture %p sub_resource_idx %u\n", src->wined3d_texture, src->sub_resource_idx);
> >
> > We usually have a period at the end of wined3d trace messages.
> > > -
> > >    WARN("source %p must be SYSTEMMEM and dest %p must be DEFAULT, returning WINED3DERR_INVALIDCALL\n",
> > > -
> > >            src_surface, dst_surface);
> > > -
> > >    wined3d_mutex_unlock();
> > > -
> > >    return D3DERR_INVALIDCALL;
> >
> > The trace message mentions the wrong return value (WINED3DERR... vs
> > D3DERR...).
> > > - hr = wined3d_device_copy_sub_resource_region(device->wined3d_device,
> > > -
> > >    wined3d_texture_get_resource(dst->wined3d_texture), dst->sub_resource_idx, dst_point ? dst_point->x : 0,
> > > -
> > >    dst_point ? dst_point->y : 0, 0, wined3d_texture_get_resource(src->wined3d_texture),
> > > -
> > >    src->sub_resource_idx, &src_box);
> >
> > Indentation (8 spaces for the line continuations).
> >
> > Stefan
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
> >
> > iQIcBAEBCAAGBQJWOKUmAAoJEN0/YqbEcdMwCaIP/A/V33gPqKBJtBJAXi8UnsEG
> > dENusnecbrxauf6Sc6x5g7cYriBUEph5ndYa96y+lv8qKuOg9jVLeoUkfBHqpE8f
> > V77p3cCnAJJ2XzbFJkqu8jY5GKvaAmoizezOyPRi/lgXa2xydH5yzW5NFu27Rbq8
> > KeG3kuBIBDzkJ1poSUvYWvSqUTGOeaUEYZBkDttqPegHvjPpYJg6MAzpr33c/F5P
> > s5ttSwhRdPFQJU3iktZKElhuUX2SBZnBwcueR4xAN+/4bRCIAhy2tnPXbQgC8Tih
> > dcQzVWCoQ+qK3nmYjDUrwvvWdEF78D+BOQzVtOOn4kHZwE1XQ7M1paV8en0uV0VS
> > D8Jdx4shCQGkxZncBsfysbEPkqgApukCFJp34JfXWFxlpVbiK6m2Y3DzsdyhGxek
> > Ky30AIY7FadUit5KWehcqDUj9Z8HOFdgcCe0KWqeFpeQn4G6t9gfJiiKYRV3m6TD
> > OxwLT+HcD4lozPARMTq6IT7pV3hOG0xdKNuTKfgji9+8RWRNz5nGa/Ml4WzS49lV
> > YHV06Nnb3ayw1CYTBoK2jwp5hBzAybdghSW7sKNJ6gLy3JFsZOKpKnr2yVxV1WD2
> > g8E5+tqwPDxgiriDOZrM5tPTc8+QLSaIm+Q59TKE3ScSvWVZArERVMtAk8/vd7BA
> > nAXvxDoQsVBSa7z+zwRC
> > =+ADb
> > -----END PGP SIGNATURE-----