Re: shell32 patch 26

[Alexandre Julliard]

"Martin Fuchs"  writes:
>  /* process the IDList */
> - if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/
> - if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes SEE_MASK_IDLIST */

If you only care about the MASK_IDLIST flag you should check just that
flag, otherwise the test is confusing since the 0x08 flag doesn't mean
anything by itself.

shell32 patch 26

[Martin Fuchs]

> >  /* process the IDList */
> > - if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST)
>
> /*0x0c*/
> > - if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes
>
> SEE_MASK_IDLIST */
>
> If you only care about the MASK_IDLIST flag you should check just that
> flag, otherwise the test is confusing since the 0x08 flag doesn't mean
> anything by itself.

OK, then please change the test to use only SEE_MASK_IDLIST.

Thanks,

Martin