Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit

[Stefan Dösinger]

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski:
> This patch sets the conditional NPOT bit only when required. If an
> implementation has full support for NPOT textures through the
> ARB_texture_non_power_of_two extension, then support for the subset of
> capabilities provided by the ARB_texture_rectangle extension is implied.
>
> dlls/wined3d/directx.c |    7 +++++--
>   1 files changed, 5 insertions(+), 2 deletions(-)

I am not sure if we shouldn't set NONPOWER2CONDITIONAL unconditionally if POW2 
is set. WineD3D emulates np2 textures by using a texture of the next pow2size 
and adjusting the texture matrix accordingly. This doesn't work for shaders 
though, but mipmapping and other things are supported.

[PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit

[H. Verbeet]

On 29/03/07, Stefan Dösinger  wrote:
> Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski:
> > This patch sets the conditional NPOT bit only when required. If an
> > implementation has full support for NPOT textures through the
> > ARB_texture_non_power_of_two extension, then support for the subset of
> > capabilities provided by the ARB_texture_rectangle extension is implied.
> >
> > dlls/wined3d/directx.c |    7 +++++--
> >   1 files changed, 5 insertions(+), 2 deletions(-)
>
> I am not sure if we shouldn't set NONPOWER2CONDITIONAL unconditionally if POW2
> is set. WineD3D emulates np2 textures by using a texture of the next pow2size
> and adjusting the texture matrix accordingly. This doesn't work for shaders
> though, but mipmapping and other things are supported.

That's not what NONPOWER2CONDITIONAL is for. The cap basically means
that a card has broken ATI NPOT support.