Re: ntdll: Declare some functions static

[Marcus Meissner]

On Wed, Jan 17, 2007 at 08:20:32PM +0000, Andrew Talbot wrote:
> Changelog:
>     ntdll: Declare some functions static.
>
> diff -urN a/dlls/ntdll/exception.c b/dlls/ntdll/exception.c
> --- a/dlls/ntdll/exception.c	2007-01-10 22:13:12.000000000 +0000
> +++ b/dlls/ntdll/exception.c	2007-01-17 20:11:06.000000000 +0000
> @@ -374,7 +374,7 @@
>  /***********************************************************************
> -
> RtlRaiseException (NTDLL.@)
>
> */
> -void WINAPI __regs_RtlRaiseException( EXCEPTION_RECORD *rec, CONTEXT *context )
> +static void WINAPI __regs_RtlRaiseException( EXCEPTION_RECORD *rec, CONTEXT *context )
>  {
>      NTSTATUS status = raise_exception( rec, context, TRUE );
>      if (status != STATUS_SUCCESS)
> @@ -624,7 +624,7 @@
> - ntdll-specific implementation to avoid depending on kernel functions.
> - Can be removed once ntdll.spec no longer contains stubs.
>
> */
> -void __wine_spec_unimplemented_stub( const char *module, const char *function )
> +static void __wine_spec_unimplemented_stub( const char *module, const char *function )
>  {
>      EXCEPTION_RECORD record;

This is not a good idea, it will optimize those functions away, since gcc cannot look
into the DEFINE_REGS_ENTRYPOINT() assembly.

Ciao, Marcs

ntdll: Declare some functions static

[Andrew Talbot]

Marcus Meissner wrote:
> This is not a good idea, it will optimize those functions away, since gcc
> cannot look into the DEFINE_REGS_ENTRYPOINT() assembly.
>
> Ciao, Marcs

Hi Marcus,

Thanks for putting me straight. I accidentally submitted this patch before
realising that I had forgotten to rebuild Wine.

-- Andy.