Re: shell32 patch 23e

[Alexandre Julliard]

"Martin Fuchs"  writes:
> -
> 	/* Add double quotation marks unless we already have them (e.g.: "%1" %* for exefile) */
> -
> 	if (res != out && *(res - 1) == '"')
> -
> 	{
> -
> 	    strcpyW(res, cmd);
> -
> 	    res += strlenW(cmd);
> -
> 	}
> -
> 	else
> -
> 	{
> -
> 	    strcpyW(res, cmd);
> -
> 	    res += strlenW(cmd);
> -
> 	}

Shouldn't you be doing something different in the else branch?
Otherwise that test doesn't seem very useful ;-)