Re: Difficulties with Regression Testing

[James Mckenzie]

> From: Austin English 
> Sent: Nov 19, 2009 10:31 AM
> To: James Mckenzie 
> Cc: Wine Development Mailing List 
> Subject: Re: Difficulties with Regression Testing
>
> On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie
>  wrote:
> > All:
> >
> > I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE
> > patch or to discover what I need to do to fix the patch to make it work with wine-1.1.11.  I've been following the
> > instructions on the Regression Testing Wiki page.  I am on the fourth git bisect good and I run into two different
> > problems:
> > - The tools/Makefile.in file gets corrupted on the fourth git bisect good.  This is unexpected as I am not aware of
> >
> > any changes to this file that would cause corruption.  This happens interrmittently and a git fetch sometimes causes
> > the error that tools/Makefile.in needs to be updated to appear when I apply/remove a patch which is needed to correct
> > wordpad, one of the programs I am using to test the EM_FORMATRANGE patch.  The build fails when attempting to build
> > makedep.c.  The includes appear to be incorrect and do not pick up the files in the source directory thus the Wine
> > includes are not included.
>
> Try doing a make clean / make distclean.

I don't think this will do anything, but I'll try it.
> > - Something else is causing the check.bmp file not to be found and thus the tests fail on the fourth git bisect
> >
> > good.   The .rc file that calls this file is located in two different directorys but the check.bmp file only exists in
> > the tools/subdirectory.
>
> IIRC, that was a file for the cryptui manager that AJ forgot to
> include with the commit needing it. Try either putting it there
> manually from another git branch, or using make -k.

Where does this need to be added?  I might be able to figure it out, but I don't want to go guessing.

James McKenzie

Difficulties with Regression Testing

[Austin English]

On Thu, Nov 19, 2009 at 9:41 AM, James Mckenzie
 wrote:
> > From: Austin English 
> > Sent: Nov 19, 2009 10:31 AM
> > To: James Mckenzie 
> > Cc: Wine Development Mailing List 
> > Subject: Re: Difficulties with Regression Testing
> >
> > On Thu, Nov 19, 2009 at 8:51 AM, James Mckenzie
> >  wrote:
> > > All:
> > >
> > > I've been running regression tests to find a commit between wine-1.1.10 and wine-1.1.11 that breaks the EM_FORMATRANGE
> > > patch or to discover what I need to do to fix the patch to make it work with wine-1.1.11.  I've been following the
> > > instructions on the Regression Testing Wiki page.  I am on the fourth git bisect good and I run into two different
> > > problems:
> > > - The tools/Makefile.in file gets corrupted on the fourth git bisect good.  This is unexpected as I am not aware of
> > >
> > > any changes to this file that would cause corruption.  This happens interrmittently and a git fetch sometimes causes
> > > the error that tools/Makefile.in needs to be updated to appear when I apply/remove a patch which is needed to correct
> > > wordpad, one of the programs I am using to test the EM_FORMATRANGE patch.  The build fails when attempting to build
> > > makedep.c.  The includes appear to be incorrect and do not pick up the files in the source directory thus the Wine
> > > includes are not included.
> >
> > Try doing a make clean / make distclean.
>
> I don't think this will do anything, but I'll try it.

Ah, Makefile.in...nm, misread that. Not sure then.
> > > - Something else is causing the check.bmp file not to be found and thus the tests fail on the fourth git bisect
> > >
> > > good.   The .rc file that calls this file is located in two different directorys but the check.bmp file only exists in
> > > the tools/subdirectory.
> >
> > IIRC, that was a file for the cryptui manager that AJ forgot to
> > include with the commit needing it. Try either putting it there
> > manually from another git branch, or using make -k.
>
> Where does this need to be added?  I might be able to figure it out, but I don't want to go guessing.

Put it in dlls/cryptui/, or just use make -k to ignore it.

Difficulties with Regression Testing

[James McKenzie]

Austin English wrote:
> On Thu, Nov 19, 2009 at 9:41 AM, James Mckenzie
>  wrote:
> > > From: Austin English 
> > > Sent: Nov 19, 2009 10:31 AM
> > > To: James Mckenzie 
> > > Cc: Wine Development Mailing List 
> > > Subject: Re: Difficulties with Regression Testing
> > > > - Something else is causing the check.bmp file not to be found and thus the tests fail on the fourth git bisect
> > > >
> > > > good.   The .rc file that calls this file is located in two different directorys but the check.bmp file only exists in
> > > > the tools/subdirectory.
> > >
> > > IIRC, that was a file for the cryptui manager that AJ forgot to
> > > include with the commit needing it. Try either putting it there
> > > manually from another git branch, or using make -k.
> >
> > Where does this need to be added?  I might be able to figure it out, but I don't want to go guessing.
>
> Put it in dlls/cryptui/, or just use make -k to ignore it.

Thanks.  The bug was not in that bisect.  However, it did appear later
in the sequence.  Only two revisions left to test now.

James McKenzie